From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya4F4-0006cd-OZ for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:26:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya4F0-0007He-NT for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:26:14 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:37635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya4F0-0007HW-H0 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:26:10 -0400 Message-ID: <55103067.5010700@suse.com> Date: Mon, 23 Mar 2015 23:25:27 +0800 From: Lin Ma MIME-Version: 1.0 References: <1427105442-23484-1-git-send-email-lma@suse.com> <55100C94.104@suse.de> In-Reply-To: <55100C94.104@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl Reply-To: lma@suse.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org 在 2015年03月23日 20:52, Andreas Färber 写道: > Hi Lin, > > Am 23.03.2015 um 11:10 schrieb Lin Ma: >> Add can_be_deleted callback, If it is not null and returns false, >> The qmp_object_del won't delete the given object. >> >> Signed-off-by: Lin Ma >> --- >> include/qom/object.h | 12 ++++++++++++ >> qmp.c | 7 +++++++ >> qom/object.c | 12 ++++++++++++ >> 3 files changed, 31 insertions(+) > Why am I not being CC'ed here as QOM maintainer? You can use > scripts/get_maintainer.pl to assist you, or read MAINTAINERS file. Really sorry about that. > > Also, when sending more than one patch, always include a cover letter > for grouping. Thanks for reminding. > It further seems that this is the second version already, so you > should've used --subject-prefix="PATCH v2" and included a change log in > the cover letter. > > Cf. http://wiki.qemu-project.org/Contribute/SubmitAPatch > > Regards, > Andreas > Because the patch v1 is a single patch and not generic, So I dropped it. That's why I didn't used --subject-prefix here. But I'll add all the info & format that you mentioned in patch v3. Thanks, Lin