From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya4a6-0001Ne-3O for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:47:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya4a0-0006PL-7h for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:47:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya4a0-0006P1-04 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 11:47:52 -0400 Message-ID: <5510359F.8080400@redhat.com> Date: Mon, 23 Mar 2015 16:47:43 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <55102594.6000902@redhat.com> <55102EB4.6010106@redhat.com> <551030F7.6030702@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] RFC: memory API changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , QEMU Developers , Greg Bellows , "Edgar E. Iglesias" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Richard Henderson On 23/03/2015 16:39, Peter Maydell wrote: > > Not necessarily, for example PCI devices can certainly > > use the short name. > > PCI devices should all be using ld*_pci_dma and st*_pci_dma > so they go through the correct address space for the PCIDevice. > Any PCI device making direct calls to ld*_phys/st*_phys > is broken... Ok, so most ld*_phys users are already using cs->as. The remaining ones are: hw/alpha/typhoon.c hw/display/sm501_template.h hw/dma/pl080.c hw/dma/sun4m_iommu.c hw/net/vmware_utils.h hw/pci-host/apb.c hw/s390x/css.c hw/s390x/s390-pci-bus.c hw/s390x/s390-virtio-bus.c hw/s390x/virtio-ccw.c hw/scsi/megasas.c hw/scsi/vmw_pvscsi.c So let's keep ld*_phys in cpu-common.h, fix the uses above, and then move it to cpu-all.h (cpu-common.h probably should die). Paolo