From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property
Date: Mon, 23 Mar 2015 16:58:00 +0100 [thread overview]
Message-ID: <55103808.8000203@redhat.com> (raw)
In-Reply-To: <CAEgOgz66sXnZx-Sj0AGugXw47AbY3rox4YUdSV7WgW_0L6fa+A@mail.gmail.com>
On 23/03/2015 16:01, Peter Crosthwaite wrote:
> Note that SD has a SPI mode, every SD card is in theory a valid SSI
> device. We could unify SD under SSI to achieve both QOMification and
> busification.
That wouldn't really be the way most SD cards work, anyway. The
protocol doesn't do simultaneous bidirectional transfers like SSI does.
With your proposal the right way to invoke sdhci-pci would be "-device
sdhci-pci,id=sdhci -drive if=none,...,id=sd -device
sd,drive=sd,bus=sdhci.0".
Similarly, instantiating an SD card on an SSI bus would be "-device
ssi-sd,id=ssisd -drive if=none,...,id=sd -device sd,drive=sd,bus=ssisd.0".
> I would then expect the block setup of sd.c to be very similar to
> hw/block/m25p80.c (SPI flash).
Absolutely not, hw/block/m25p80.c has the same issue of doing
drive_get_next in the realize function.
Paolo
next prev parent reply other threads:[~2015-03-23 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 15:54 [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property Paolo Bonzini
2015-03-23 9:10 ` Markus Armbruster
2015-03-23 12:05 ` Paolo Bonzini
2015-03-23 12:09 ` Peter Maydell
2015-03-23 13:19 ` Paolo Bonzini
2015-03-23 13:43 ` Markus Armbruster
2015-03-23 13:35 ` Markus Armbruster
2015-03-23 13:56 ` Paolo Bonzini
2015-03-23 15:01 ` Peter Crosthwaite
2015-03-23 15:15 ` Peter Maydell
2015-03-23 15:58 ` Paolo Bonzini [this message]
2015-03-24 14:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55103808.8000203@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).