From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43132)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ya5FP-0002BC-L0
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:30:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ya5FM-0003AC-6B
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:30:39 -0400
Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:33611)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ya5FL-0003A8-W7
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:30:36 -0400
Received: by weop45 with SMTP id p45so142367249weo.0
	for <qemu-devel@nongnu.org>; Mon, 23 Mar 2015 09:30:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <55103FA7.10402@redhat.com>
Date: Mon, 23 Mar 2015 17:30:31 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAFEAcA-8AmagfK1NBE02J7kLEvVNdcm_oRbEmJpWAArL-2jc2Q@mail.gmail.com>	<55102594.6000902@redhat.com>	<CAFEAcA9jnHpn4AF9FsQ7gT6n0MAEV018gkLcoV5i9TnwVXS0_A@mail.gmail.com>	<55102EB4.6010106@redhat.com>	<CAFEAcA9BooQqH3K8xKrHH2w9A0MqbeSJCw=5iTg2b9bpNKG0gA@mail.gmail.com>	<551030F7.6030702@redhat.com>	<CAFEAcA9cOcEBUuEvThGbdX-Vda-hAJHgorAEdECy72qTiuahrA@mail.gmail.com>	<5510359F.8080400@redhat.com>
	<CAFEAcA_r3_b3z34nMQ9GCTXYDhd8qLASpQHMFDVJ-4nN4R+_QQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_r3_b3z34nMQ9GCTXYDhd8qLASpQHMFDVJ-4nN4R+_QQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] RFC: memory API changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Greg Bellows <greg.bellows@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>



On 23/03/2015 17:00, Peter Maydell wrote:
> On 23 March 2015 at 15:47, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Ok, so most ld*_phys users are already using cs->as.
> 
> But this is only because when the AddressSpace* argument
> to ld*_phys was introduced we made it be cs->as for
> existing callers, to retain the existing behaviour.
> That doesn't mean that callers using cs->as are doing
> the right thing. In general I would expect that any
> caller that's not part of the CPU itself should not be
> rummaging around inside the CPU struct to find an
> AddressSpace to use...

None of them does, uses of ld*_phys(cs->as, ...) are almost all in
target-* already.

There's just hw/ppc/spapr_hcall.c and hw/ppc/spapr_iommu.c that are
using cs->as in hw/, but they are correct because these are hypercalls.

The others use &address_space_memory.  I sent a patch to fix megasas and
vmware.

Paolo