From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya5H8-0003OI-D7 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:32:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya5H5-0003Y5-5l for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:32:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49129 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya5H4-0003Xy-W0 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:32:23 -0400 Message-ID: <55104015.1010003@suse.de> Date: Mon, 23 Mar 2015 17:32:21 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <55102594.6000902@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] RFC: memory API changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Peter Maydell , Peter Crosthwaite , QEMU Developers , Paolo Bonzini , Greg Bellows , Chen Fan , "Edgar E. Iglesias" , Richard Henderson Am 23.03.2015 um 16:11 schrieb Peter Maydell: > On 23 March 2015 at 14:39, Paolo Bonzini wrote: >> On 23/03/2015 13:24, Peter Maydell wrote: >>> * cpu_physical_memory_rw are obsolete and should be replaced >>> with uses of the as_* functions -- we should at least note >>> this in the header file. (Can't do this as an automated change >>> really because the correct AS to use is callsite dependent.) >> >> All users that should _not_ be using address_space_memory have been >> already changed to address_space_rw, or should have, so it can be done >> automatically. Same for cpu_physical_memory_map/unmap, BTW. >=20 > Hmm. Checking a few, I notice that for instance the kvm-all.c > cpu_physical_memory_rw() should probably be using cpu->as. [snip] Igor, does that impact our APIC discussion? Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)