From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya5Jr-0005gv-04 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:35:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya5Jn-0004u7-Jx for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:35:14 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:48421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya5Jn-0004u2-D8 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 12:35:11 -0400 Message-ID: <55104F35.4020506@mail.uni-paderborn.de> Date: Mon, 23 Mar 2015 18:36:53 +0100 From: Bastian Koppelmann MIME-Version: 1.0 References: <1425739412-8144-1-git-send-email-sw@weilnetz.de> <55102612.7040303@mail.uni-paderborn.de> In-Reply-To: <55102612.7040303@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-tricore: Fix two helper functions (clang warnings) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , QEMU Developer Cc: Peter Maydell Hi Stefan, On 03/23/2015 03:41 PM, Bastian Koppelmann wrote: > [snip] > > The code for dvinit.b and dvinit.h is not correctly calculating the > overflow bit, but I can't figure out why, since the documentation of > the real hardware seems to be wrong. I will take your patch for now, > so the warning is gone and try to come up with a proper fix as soon as > possible. > > Cheers, > Bastian > I have the proper fix now and will send a patch to the list in a few minutes. I'll keep your patch and will apply the fix on top of it. Cheers, Bastian