From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing
Date: Mon, 23 Mar 2015 11:48:17 -0600 [thread overview]
Message-ID: <551051E1.2030603@redhat.com> (raw)
In-Reply-To: <55104C17.80407@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On 03/23/2015 11:23 AM, Paolo Bonzini wrote:
>
>
> On 20/03/2015 15:19, Markus Armbruster wrote:
>>> If (a working version of) this makes it in 2.3, libvirt WILL use it in
>>> the next release. It will take me less than 5 minutes to write up the
>>> libvirt patch, as long as the new option is advertised via
>>> query-command-line-options (which means that QMP introspection of the
>>> new option is a must for v2 :)
>
> Why can't libvirt just add ,format=raw instead of leaving out the format
> key altogether?
Libvirt DOES add format=raw. This patch is an extra insurance policy to
guarantee that libvirt does not have any code paths that omit the
explicit format (as we have had a couple of CVEs in libvirt over the
years where that was the case).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-23 17:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 13:05 [Qemu-devel] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing Markus Armbruster
2015-03-20 13:05 ` [Qemu-devel] [PATCH RFC for-2.3 1/1] " Markus Armbruster
2015-03-20 13:34 ` Max Reitz
2015-03-20 13:48 ` Markus Armbruster
2015-03-20 13:49 ` Max Reitz
2015-03-20 13:56 ` Eric Blake
2015-03-20 14:19 ` Markus Armbruster
2015-03-20 14:32 ` Eric Blake
2015-03-23 17:23 ` Paolo Bonzini
2015-03-23 17:48 ` Eric Blake [this message]
2015-03-23 17:50 ` Paolo Bonzini
2015-03-23 20:19 ` Markus Armbruster
2015-03-24 8:37 ` Paolo Bonzini
2015-03-24 14:22 ` [Qemu-devel] [Qemu-block] " Eric Blake
2015-03-24 16:49 ` [Qemu-devel] " Markus Armbruster
2015-03-24 20:11 ` Paolo Bonzini
2015-03-25 8:10 ` Markus Armbruster
2015-03-25 10:36 ` Paolo Bonzini
2015-03-20 14:01 ` [Qemu-devel] [PATCH RFC for-2.3 0/1] " Eric Blake
2015-03-20 14:27 ` Markus Armbruster
2015-03-20 14:17 ` [Qemu-devel] [RFC PATCH] qemu: enforce no format probing when possible Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551051E1.2030603@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).