From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya6Se-0003F4-6z for qemu-devel@nongnu.org; Mon, 23 Mar 2015 13:48:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya6Sa-0001fX-72 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 13:48:24 -0400 Message-ID: <551051E1.2030603@redhat.com> Date: Mon, 23 Mar 2015 11:48:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426856744-18750-1-git-send-email-armbru@redhat.com> <1426856744-18750-2-git-send-email-armbru@redhat.com> <550C21DB.8000607@redhat.com> <87h9tf7pbi.fsf@blackfin.pond.sub.org> <550C2577.2010201@redhat.com> <550C26FE.6010807@redhat.com> <87384z4uq4.fsf@blackfin.pond.sub.org> <55104C17.80407@redhat.com> In-Reply-To: <55104C17.80407@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ltafBatWBaIM5V2mXkXf2HMw9I5bIRJ1B" Subject: Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Markus Armbruster Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ltafBatWBaIM5V2mXkXf2HMw9I5bIRJ1B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/23/2015 11:23 AM, Paolo Bonzini wrote: >=20 >=20 > On 20/03/2015 15:19, Markus Armbruster wrote: >>> If (a working version of) this makes it in 2.3, libvirt WILL use it i= n >>> the next release. It will take me less than 5 minutes to write up th= e >>> libvirt patch, as long as the new option is advertised via >>> query-command-line-options (which means that QMP introspection of the= >>> new option is a must for v2 :) >=20 > Why can't libvirt just add ,format=3Draw instead of leaving out the for= mat > key altogether? Libvirt DOES add format=3Draw. This patch is an extra insurance policy t= o guarantee that libvirt does not have any code paths that omit the explicit format (as we have had a couple of CVEs in libvirt over the years where that was the case). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ltafBatWBaIM5V2mXkXf2HMw9I5bIRJ1B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVEFHhAAoJEKeha0olJ0NqToUIAK3kHVIGJ9tFCYaqfpd2wW78 iNSVsYMJGG7Yv/BzWCR3w2KwjIjv6BLnIBSphE8rcT9QtGaPgGqsq638vVCHDuXD 6HZm2Sef8+lspeign7y8E0bP7nZ3wLGBqoN98ItC+AsZNxrqxw8gKxLyWN3MyDMM EGzziIa0NJPgpPGBV6Y+0c6qLTGYn9DdSsDvJPV32y1jvVC4Ki1sKg2cjEYA+23F +pQhEzd54ikrpLzfezWVBusqgxoQb1QhNe46w5HocWG90ZeRvsmdxgvm8nvn03yx BiqhG1j7qfaTaIa/9Ufdx0sCRaq4IWQDCkRByTENBUzx8mMq06/k/Y/nIaX9YlM= =iHpi -----END PGP SIGNATURE----- --ltafBatWBaIM5V2mXkXf2HMw9I5bIRJ1B--