From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya8Wn-0000A6-FN for qemu-devel@nongnu.org; Mon, 23 Mar 2015 16:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya8Wk-0001UF-7r for qemu-devel@nongnu.org; Mon, 23 Mar 2015 16:00:49 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:51223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya8Wk-0001Tl-4s for qemu-devel@nongnu.org; Mon, 23 Mar 2015 16:00:46 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Mar 2015 16:00:43 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 89E666E8058 for ; Mon, 23 Mar 2015 15:52:31 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2NK0fLX27197510 for ; Mon, 23 Mar 2015 20:00:41 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2NK0dmc028664 for ; Mon, 23 Mar 2015 16:00:40 -0400 Message-ID: <551070E6.9050506@linux.vnet.ibm.com> Date: Mon, 23 Mar 2015 16:00:38 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1425989764-2926-1-git-send-email-quan.xu@intel.com> <1425989764-2926-2-git-send-email-quan.xu@intel.com> <1426769810.610.64.camel@citrix.com> <550C07EF.6010105@linux.vnet.ibm.com> <945CA011AD5F084CBEA3E851C0AB28890E8C71A3@SHSMSX101.ccr.corp.intel.com> <550FF18F.1010203@linux.vnet.ibm.com> <945CA011AD5F084CBEA3E851C0AB28890E8C74DB@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28890E8C74DB@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Xu, Quan" , Ian Campbell Cc: "kevin@koconnor.net" , "xen-devel@lists.xen.org" , "qemu-devel@nongnu.org" , "stefano.stabellini@eu.citrix.com" On 03/23/2015 08:03 AM, Xu, Quan wrote: > >> -----Original Message----- >> From: Stefan Berger [mailto:stefanb@linux.vnet.ibm.com] >> Sent: Monday, March 23, 2015 6:57 PM >> To: Xu, Quan; Ian Campbell >> Cc: kevin@koconnor.net; xen-devel@lists.xen.org; qemu-devel@nongnu.org; >> stefano.stabellini@eu.citrix.com >> Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for >> HVM virtual machine >> >> On 03/22/2015 09:47 PM, Xu, Quan wrote: >>>> -----Original Message----- >>>> From: Stefan Berger [mailto:stefanb@linux.vnet.ibm.com] >>>> Sent: Friday, March 20, 2015 7:44 PM >>>> To: Ian Campbell; Xu, Quan >>>> Cc: kevin@koconnor.net; xen-devel@lists.xen.org; >>>> qemu-devel@nongnu.org; stefano.stabellini@eu.citrix.com >>>> Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom >>>> vTPM for HVM virtual machine >>>> >>>> On 03/19/2015 08:56 AM, Ian Campbell wrote: >>>>> On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: >>>>>> @@ -151,6 +152,8 @@ device_hardware_setup(void) >>>>>> esp_scsi_setup(); >>>>>> megasas_setup(); >>>>>> pvscsi_setup(); >>>>>> + if (runningOnXen()) >>>>>> + vtpm4hvm_setup(); >>>>> Is there anything which is actually Xen specific about the driver in >>>>> tpm.[ch]? Would it be better to just probe for it, perhaps gates by >>>>> a Kconfig option which enables TPM support. >>>> I also think the probing should be done. That code can also be >>>> recycled from what I posted earlier. It's gated by a Kconfig option, so it doesn't >> fill up the 128k ROM. >>>> Stefan >>>> >>> Agree, I will do it ASAP. >> I reposted v9 of my series of patches. I will probably post v10 today. >> Please try that one then since these patches should cover Xen, QEMU (using a >> driver that only I can test at the moment), and to some extent bare metal >> system. >> >> >> Stefan >> > Great! Could you also archive v10 to your github? > then I can also test it and go through these source code. I put it here now: https://github.com/stefanberger/seabios-tpm Stefan