From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaCOA-00065Z-3d for qemu-devel@nongnu.org; Mon, 23 Mar 2015 20:08:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaCO6-0002L4-Rq for qemu-devel@nongnu.org; Mon, 23 Mar 2015 20:08:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39421 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaCO6-0002Ko-LR for qemu-devel@nongnu.org; Mon, 23 Mar 2015 20:08:06 -0400 Message-ID: <5510AAE3.8050007@suse.de> Date: Tue, 24 Mar 2015 01:08:03 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1427012810-8400-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1427012810-8400-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] rcu tests: fix compilation on 32-bit ppc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Am 22.03.2015 um 09:26 schrieb Paolo Bonzini: > 32-bit PPC cannot do atomic operations on long long. Inside the loops, > we are already using local counters that are summed at the end of > the run---with some exceptions (rcu_stress_count for rcutorture, > n_nodes for test-rcu-list): fix them to use the same technique. > For test-rcu-list, remove the mostly unused member "val" from the > list. Then, use a mutex to protect the global counts. >=20 > Performance does not matter there because every thread will only enter > the critical section once. >=20 > Remaining uses of atomic instructions are for ints or pointers. >=20 > Reported-by: Andreas Faerber > Signed-off-by: Paolo Bonzini > --- > tests/rcutorture.c | 20 ++++++++++++++++---- > tests/test-rcu-list.c | 50 ++++++++++++++++++++++++++++---------------= ------- > 2 files changed, 44 insertions(+), 26 deletions(-) Tested-by: Andreas F=E4rber Passing these tests now, but running into unrelated qtest failures. Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)