From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaKUi-0001qA-Fg for qemu-devel@nongnu.org; Tue, 24 Mar 2015 04:47:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaKUe-0004di-CX for qemu-devel@nongnu.org; Tue, 24 Mar 2015 04:47:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:56190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaKUe-0004dQ-7A for qemu-devel@nongnu.org; Tue, 24 Mar 2015 04:47:24 -0400 Message-ID: <55112498.2040108@intel.com> Date: Tue, 24 Mar 2015 16:47:20 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1427073466-16956-1-git-send-email-tiejun.chen@intel.com> <1427073466-16956-3-git-send-email-tiejun.chen@intel.com> In-Reply-To: <1427073466-16956-3-git-send-email-tiejun.chen@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ian.campbell@citrix.com, wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com, stefano.stabellini@citrix.com Cc: Kevin , qemu-devel@nongnu.org, xen-devel@lists.xen.org All guys, Sorry to bother you. I have a question to two files, tools/python/xen/lowlevel/xc/xc.c and tools/python/xen/lowlevel/xl/xl.c. Who is a caller to those methods like pyxc_methods[] and pyxl_methods[]? And how should we call these approaches? In my specific case, I'm trying to introduce a new flag to each a device while assigning device. So this means I have to add a parameter, 'flag', into int xc_assign_device( xc_interface *xch, uint32_t domid, uint32_t machine_sbdf) Then this is extended as int xc_assign_device( xc_interface *xch, uint32_t domid, uint32_t machine_sbdf, uint32_t flag) After this introduction, obviously I should cover all cases using xc_assign_device(). And also I found this fallout goes into these two files. For example, here pyxc_assign_device() is involved. Currently it has two parameters, 'dom' and 'pci_str', and as I understand 'pci_str' should represent all pci devices with SBDF format, right? But I don't know exactly what rule should be complied to construct this sort of flag into 'pci_str', or any reasonable idea to achieve my goal? Thanks Tiejun