From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaQAO-0002lQ-QD for qemu-devel@nongnu.org; Tue, 24 Mar 2015 10:50:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaQAI-0007Na-SC for qemu-devel@nongnu.org; Tue, 24 Mar 2015 10:50:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaQAI-0007NG-It for qemu-devel@nongnu.org; Tue, 24 Mar 2015 10:50:46 -0400 Message-ID: <551179BB.4040201@redhat.com> Date: Tue, 24 Mar 2015 15:50:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1427137790-27265-1-git-send-email-armbru@redhat.com> <55113AE7.1070506@redhat.com> <877fu68ssm.fsf@blackfin.pond.sub.org> In-Reply-To: <877fu68ssm.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org, michael@walle.cc, edgar.iglesias@gmail.com, =?windows-1252?Q?Andreas_F=E4rber?= On 24/03/2015 13:48, Markus Armbruster wrote: > Use of -drive if=floppy with onboard pc87312 (machine "prep") shouldn't > be affected. Likewise for connecting onboard m25p80-generic derivatives > with if=mtd drives, or onboard ssi-sd with if=sd. Exactly. > Weird usage similar to the one you caught in time for sdhci-pci (--drive > if=sd --device sdhci-pci) would break. It's possible when the target > has the device, and the machine type has a suitable bus. > > * pc87312 > > Depends on CONFIG_PC87312, set in {ppc,ppc64}-softmmu.mak. > > Requires an ISA bus. I believe "prep" is the only machine providing > one. You can add one with -device i82378. Actually used in tests/endianness-test.c, hence I guess supported. > If Andreas agrees, I can set cannot_instantiate_with_device_add_yet > for pc87312 now. Could do that, could also decide that "-device i82378 -device pc87312" is a valid way to add all the legacy crap to a PCI machine. In which case supporting "-drive if=floppy" is a weird feature but it's also hard to call it a bug. The difference with other devices is that you can only add it once. It's a big difference. > * ssi-sd > > I guess we want to document that --device ssi-sd will at some point > cease to auto-connect to the next available if=sd drive and require > the usual drive property instead. Okay? > > * m25p80-generic > > Document just like ssi-sd. Ack for these two. Boards can still hook -drive if={sd,mtd} to them, but (hypothetical) users would have to switch to -drive if=none. Paolo > [...] >> Acked-by: Paolo Bonzini > > Thanks! >