From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaQeh-0003jy-CJ for qemu-devel@nongnu.org; Tue, 24 Mar 2015 11:22:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaQec-0002XX-TB for qemu-devel@nongnu.org; Tue, 24 Mar 2015 11:22:11 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:58615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaQec-0002Wy-Lv for qemu-devel@nongnu.org; Tue, 24 Mar 2015 11:22:06 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Mar 2015 09:22:05 -0600 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id C3A0B19D8026 for ; Tue, 24 Mar 2015 09:13:09 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2OFM2QE28639270 for ; Tue, 24 Mar 2015 08:22:03 -0700 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2OFLrjM001424 for ; Tue, 24 Mar 2015 09:21:54 -0600 Message-ID: <55118109.4090900@linux.vnet.ibm.com> Date: Tue, 24 Mar 2015 11:21:45 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1425989764-2926-1-git-send-email-quan.xu@intel.com> <1425989764-2926-2-git-send-email-quan.xu@intel.com> <1426769810.610.64.camel@citrix.com> <550C07EF.6010105@linux.vnet.ibm.com> <945CA011AD5F084CBEA3E851C0AB28890E8C71A3@SHSMSX101.ccr.corp.intel.com> <550FF18F.1010203@linux.vnet.ibm.com> <945CA011AD5F084CBEA3E851C0AB28890E8C74DB@SHSMSX101.ccr.corp.intel.com> <551070E6.9050506@linux.vnet.ibm.com> <945CA011AD5F084CBEA3E851C0AB28890E8C7CB6@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28890E8C7CB6@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Xu, Quan" , Ian Campbell Cc: "wei.liu2@citrix.com" , "stefano.stabellini@eu.citrix.com" , "qemu-devel@nongnu.org" , "xen-devel@lists.xen.org" , "kevin@koconnor.net" , Jan Beulich On 03/23/2015 10:20 PM, Xu, Quan wrote: > >> -----Original Message----- >> From: Stefan Berger [mailto:stefanb@linux.vnet.ibm.com] >> Sent: Tuesday, March 24, 2015 4:01 AM >> To: Xu, Quan; Ian Campbell >> Cc: kevin@koconnor.net; qemu-devel@nongnu.org; >> stefano.stabellini@eu.citrix.com; xen-devel@lists.xen.org >> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen >> stubdom vTPM for HVM virtual machine >> >> On 03/23/2015 08:03 AM, Xu, Quan wrote: >>>> -----Original Message----- >>>> From: Stefan Berger [mailto:stefanb@linux.vnet.ibm.com] >>>> Sent: Monday, March 23, 2015 6:57 PM >>>> To: Xu, Quan; Ian Campbell >>>> Cc: kevin@koconnor.net; xen-devel@lists.xen.org; >>>> qemu-devel@nongnu.org; stefano.stabellini@eu.citrix.com >>>> Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom >>>> vTPM for HVM virtual machine >>>> >>>> On 03/22/2015 09:47 PM, Xu, Quan wrote: >>>>>> -----Original Message----- >>>>>> From: Stefan Berger [mailto:stefanb@linux.vnet.ibm.com] >>>>>> Sent: Friday, March 20, 2015 7:44 PM >>>>>> To: Ian Campbell; Xu, Quan >>>>>> Cc: kevin@koconnor.net; xen-devel@lists.xen.org; >>>>>> qemu-devel@nongnu.org; stefano.stabellini@eu.citrix.com >>>>>> Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom >>>>>> vTPM for HVM virtual machine >>>>>> >>>>>> On 03/19/2015 08:56 AM, Ian Campbell wrote: >>>>>>> On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: >>>>>>>> @@ -151,6 +152,8 @@ device_hardware_setup(void) >>>>>>>> esp_scsi_setup(); >>>>>>>> megasas_setup(); >>>>>>>> pvscsi_setup(); >>>>>>>> + if (runningOnXen()) >>>>>>>> + vtpm4hvm_setup(); >>>>>>> Is there anything which is actually Xen specific about the driver >>>>>>> in tpm.[ch]? Would it be better to just probe for it, perhaps >>>>>>> gates by a Kconfig option which enables TPM support. >>>>>> I also think the probing should be done. That code can also be >>>>>> recycled from what I posted earlier. It's gated by a Kconfig >>>>>> option, so it doesn't >>>> fill up the 128k ROM. >>>>>> Stefan >>>>>> >>>>> Agree, I will do it ASAP. >>>> I reposted v9 of my series of patches. I will probably post v10 today. >>>> Please try that one then since these patches should cover Xen, QEMU >>>> (using a driver that only I can test at the moment), and to some >>>> extent bare metal system. >>>> >>>> >>>> Stefan >>>> >>> Great! Could you also archive v10 to your github? >>> then I can also test it and go through these source code. >> I put it here now: >> >> https://github.com/stefanberger/seabios-tpm >> >> Stefan > Thanks. > MS windows guest VM are maybe tricky issues. In my early-stage SeaBios patch, > I deal with TPM TCPA and SSDT in SeaBios, but MS windows guest VM is blue screens(Linux guest virtual machines are working). > It works when I deal with TPM TCPA and SSDT in hvmloader for Windows guest VM. Can you be a bit more specific as to what gets it to work or which modifications you have to make in SeaBIOS to make it work? Stefan