qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets
Date: Tue, 24 Mar 2015 12:52:26 -0400	[thread overview]
Message-ID: <5511964A.5010903@redhat.com> (raw)
In-Reply-To: <1426274523-22661-1-git-send-email-jsnow@redhat.com>

Ping: I'll pull both this series and the 'ahci: rerror/werror=stop 
resume tests' series into my ide-next branch if just these two patches 
get a re-review.

They were excised from a pullreq due to glib compatibility issues, so 
the following series has no changes.

--js

On 03/13/2015 03:22 PM, John Snow wrote:
> This is a re-send of patches 7 & 8 from an earlier series,
> "[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced
> back because I used some glib functions that were too new.
>
> v2:
> - Patchew caught a pathing problem with the qemu-img binary;
>    the relative path produced by the Makefile does not prepend
>    "./", so I was relying on the /distro's/ qemu-img by accident.
>    Fix that by using realpath().
>
> v1:
> - Removed "./" from the execution CLI. Now you can set an absolute or
>    relative path for QTEST_QEMU_IMG and it will work either way. The default
>    as generated by the Makefile will be a relative path.
>
> - Removed the g_spawn_check_exit_status glib call from mkimg(). See the
>    in-line comments in patch 1/2 for correctness justification.
>
> John Snow (2):
>    qtest/ahci: add qcow2 support to ahci-test
>    qtest/ahci: test different disk sectors
>
>   tests/Makefile        |  1 +
>   tests/ahci-test.c     | 84 +++++++++++++++++++++++++++++++++++++--------------
>   tests/libqos/ahci.c   | 10 +++---
>   tests/libqos/ahci.h   |  4 +--
>   tests/libqos/libqos.c | 44 +++++++++++++++++++++++++++
>   tests/libqos/libqos.h |  2 ++
>   6 files changed, 116 insertions(+), 29 deletions(-)
>

  parent reply	other threads:[~2015-03-24 16:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 19:22 [Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets John Snow
2015-03-13 19:22 ` [Qemu-devel] [PATCH v2 1/2] qtest/ahci: add qcow2 support to ahci-test John Snow
2015-03-13 19:22 ` [Qemu-devel] [PATCH v2 2/2] qtest/ahci: test different disk sectors John Snow
2015-03-24 16:52 ` John Snow [this message]
2015-03-25 12:55 ` [Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets Stefan Hajnoczi
2015-03-25 22:26   ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5511964A.5010903@redhat.com \
    --to=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).