From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaS4A-0006DS-3G for qemu-devel@nongnu.org; Tue, 24 Mar 2015 12:52:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaS46-0007Ie-KN for qemu-devel@nongnu.org; Tue, 24 Mar 2015 12:52:34 -0400 Message-ID: <5511964A.5010903@redhat.com> Date: Tue, 24 Mar 2015 12:52:26 -0400 From: John Snow MIME-Version: 1.0 References: <1426274523-22661-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1426274523-22661-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Ping: I'll pull both this series and the 'ahci: rerror/werror=stop resume tests' series into my ide-next branch if just these two patches get a re-review. They were excised from a pullreq due to glib compatibility issues, so the following series has no changes. --js On 03/13/2015 03:22 PM, John Snow wrote: > This is a re-send of patches 7 & 8 from an earlier series, > "[PATCH v2 0/8] ahci: add more IO tests" which ultimately got bounced > back because I used some glib functions that were too new. > > v2: > - Patchew caught a pathing problem with the qemu-img binary; > the relative path produced by the Makefile does not prepend > "./", so I was relying on the /distro's/ qemu-img by accident. > Fix that by using realpath(). > > v1: > - Removed "./" from the execution CLI. Now you can set an absolute or > relative path for QTEST_QEMU_IMG and it will work either way. The default > as generated by the Makefile will be a relative path. > > - Removed the g_spawn_check_exit_status glib call from mkimg(). See the > in-line comments in patch 1/2 for correctness justification. > > John Snow (2): > qtest/ahci: add qcow2 support to ahci-test > qtest/ahci: test different disk sectors > > tests/Makefile | 1 + > tests/ahci-test.c | 84 +++++++++++++++++++++++++++++++++++++-------------- > tests/libqos/ahci.c | 10 +++--- > tests/libqos/ahci.h | 4 +-- > tests/libqos/libqos.c | 44 +++++++++++++++++++++++++++ > tests/libqos/libqos.h | 2 ++ > 6 files changed, 116 insertions(+), 29 deletions(-) >