From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaVCf-0006gI-GH for qemu-devel@nongnu.org; Tue, 24 Mar 2015 16:13:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaVCb-0000ZW-GK for qemu-devel@nongnu.org; Tue, 24 Mar 2015 16:13:33 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:38443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaVCb-0000ZG-9d for qemu-devel@nongnu.org; Tue, 24 Mar 2015 16:13:29 -0400 Received: by wibgn9 with SMTP id gn9so8405043wib.1 for ; Tue, 24 Mar 2015 13:13:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5511C564.3060007@redhat.com> Date: Tue, 24 Mar 2015 21:13:24 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1427137790-27265-1-git-send-email-armbru@redhat.com> <55113AE7.1070506@redhat.com> <877fu68ssm.fsf@blackfin.pond.sub.org> <551179BB.4040201@redhat.com> <87d23y4e5h.fsf@blackfin.pond.sub.org> <323733322.3820871.1427214043347.JavaMail.zimbra@redhat.com> <87zj72cgdw.fsf@blackfin.pond.sub.org> In-Reply-To: <87zj72cgdw.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter maydell , peter crosthwaite , qemu-devel@nongnu.org, michael@walle.cc, edgar iglesias , =?windows-1252?Q?Andreas_F=E4rber?= On 24/03/2015 21:03, Markus Armbruster wrote: > * Of the sysbus devices only "xlnx.xps-uartlite" seems to be available > with the machines that support -device for sysbus devices (ppce500 and > pseries-*). When I try to -device it there, I get "Device > xlnx.xps-uartlite is not supported by this machine yet." I'll ask > Alex to confirm. I'll prepare a patch that sets > cannot_instantiate_with_device_add_yet for the unavailable ones to > keep them unavailable, just like for the drive_get() abusers. Right, only specific sysbus devices can be added with -device, because there is board-specific code to describe the device in the device tree. Paolo