From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52679)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1YaXpT-0003uc-8F
	for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:01:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1YaXpP-0006Ru-85
	for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:01:47 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54209 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1YaXpP-0006Rj-1o
	for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:01:43 -0400
Message-ID: <5511ECD4.1030507@suse.de>
Date: Wed, 25 Mar 2015 00:01:40 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <CAL5wTH4-=HJUvwBu+2o6jGanJesJOyNf3sL8-5+d_-6C3cWBfA@mail.gmail.com>
In-Reply-To: <CAL5wTH4-=HJUvwBu+2o6jGanJesJOyNf3sL8-5+d_-6C3cWBfA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace
 memory_region_init_ram with memory_region_allocate_system_memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?RGlyayBNw7xsbGVy?= <dirk@dmllr.de>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Leon Alrae <leon.alrae@imgtec.com>
Cc: Stefan Weil <sw@weilnetz.de>, =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, Aurelien Jarno <aurelien@aurel32.net>

Am 24.03.2015 um 22:28 schrieb Dirk M=C3=BCller:
> Commit 0b183fc871:"memory: move mem_path handling to
> memory_region_allocate_system_memory" split memory_region_init_ram and
> memory_region_init_ram_from_file. Also it moved mem-path handling a ste=
p
> up from memory_region_init_ram to memory_region_allocate_system_memory.
>=20
> Therefore for any board that uses memory_region_init_ram directly,
> -mem-path is not supported.
>=20
> Fix this by replacing memory_region_init_ram with
> memory_region_allocate_system_memory.
>=20
> Signed-off-by: Dirk Mueller <dmueller@suse.com>
> ---
>  hw/mips/mips_fulong2e.c | 3 +--
>  hw/mips/mips_jazz.c     | 5 ++---
>  hw/mips/mips_malta.c    | 5 ++---
>  hw/mips/mips_mipssim.c  | 5 ++---
>  hw/mips/mips_r4k.c      | 3 +--
>  5 files changed, 8 insertions(+), 13 deletions(-)

Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>

Leon and Paolo, I assume one of you will be handling this?

Regards,
Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG N=C3=BCrnberg)