From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaXrm-0006MB-Iq for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaXri-0007Vl-IC for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:04:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaXri-0007VX-2K for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:04:06 -0400 Message-ID: <5511ED61.8090502@redhat.com> Date: Tue, 24 Mar 2015 19:04:01 -0400 From: John Snow MIME-Version: 1.0 References: <1427237148-8728-1-git-send-email-afaerber@suse.de> <1427237148-8728-2-git-send-email-afaerber@suse.de> In-Reply-To: <1427237148-8728-2-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3 1/2] qtest: Add qtest_add_data_func() wrapper function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, stefanha@redhat.com, Anthony Liguori , peter.maydell@linaro.org On 03/24/2015 06:45 PM, Andreas F=C3=A4rber wrote: > It calls g_test_add_data_func() with a path supplemented by the > architecture, like qtest_add_func() does. > > Signed-off-by: Andreas F=C3=A4rber > --- > tests/libqtest.c | 7 +++++++ > tests/libqtest.h | 12 ++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 9a92aa7..e3f68d1 100644 > --- a/tests/libqtest.c > +++ b/tests/libqtest.c > @@ -652,6 +652,13 @@ void qtest_add_func(const char *str, void (*fn)) > g_free(path); > } > > +void qtest_add_data_func(const char *str, void *data, void (*fn)) > +{ > + gchar *path =3D g_strdup_printf("/%s/%s", qtest_get_arch(), str); > + g_test_add_data_func(path, data, fn); > + g_free(path); > +} > + > void qtest_memwrite(QTestState *s, uint64_t addr, const void *data, s= ize_t size) > { > const uint8_t *ptr =3D data; > diff --git a/tests/libqtest.h b/tests/libqtest.h > index e7413d5..e363f7f 100644 > --- a/tests/libqtest.h > +++ b/tests/libqtest.h > @@ -345,6 +345,18 @@ const char *qtest_get_arch(void); > void qtest_add_func(const char *str, void (*fn)); > > /** > + * qtest_add_data_func: > + * @str: Test case path. > + * @data: Test case data > + * @fn: Test case function > + * > + * Add a GTester testcase with the given name, data and function. > + * The path is prefixed with the architecture under test, as > + * returned by qtest_get_arch(). > + */ > +void qtest_add_data_func(const char *str, void *data, void (*fn)); > + > +/** > * qtest_start: > * @args: other arguments to pass to QEMU > * > Reviewed-by: John Snow