From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaYQu-0004Mc-3H for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:40:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaYQq-0003qv-IB for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:40:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55218 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaYQq-0003qo-BD for qemu-devel@nongnu.org; Tue, 24 Mar 2015 19:40:24 -0400 Message-ID: <5511F5E5.8000805@suse.de> Date: Wed, 25 Mar 2015 00:40:21 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1427153788-2738-1-git-send-email-kallisti5@unixzen.com> <5511E4A7.4050407@suse.de> <5511ED48.7070107@free.fr> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov , =?UTF-8?B?RnJhbsOnb2lzIFJldm9s?= Cc: Alexander von Gluck IV , qemu-devel Am 25.03.2015 um 00:11 schrieb Max Filippov: > On Wed, Mar 25, 2015 at 2:03 AM, Fran=C3=A7ois Revol wr= ote: >> On 24/03/2015 23:56, Max Filippov wrote: >>> On Wed, Mar 25, 2015 at 1:26 AM, Andreas F=C3=A4rber wrote: >>>> Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV: >>>>> >>>> >>>> Why convert from array to switch statement? It looks like a very >>>> invasive change for no obvious reason. >>> >>> I'd be interested to know the reason too, but I'm OK with either way. >> >> Maybe because negative array indices are usually a bad idea in C? >=20 > Sounds like a good reason (: True, but assumes that error codes are indeed negative. AFAIU linking with -lposix_error_helper or so (-> configure/Makefile*) may be an alternative, keeping errors POSIX-compliant in our code. I don't recall the implementation details though... Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)