From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yaja5-0001FP-Bc
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 07:34:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YajZz-0000X9-Lm
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 07:34:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58429)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YajZz-0000Wt-DA
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 07:34:35 -0400
Message-ID: <55129D3D.60403@redhat.com>
Date: Wed, 25 Mar 2015 12:34:21 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAFEAcA-8AmagfK1NBE02J7kLEvVNdcm_oRbEmJpWAArL-2jc2Q@mail.gmail.com>
	<CAFEAcA8e3YwooQJHckMyuFO2yvDeDy73pj9LQ7Digj2DfzrUKQ@mail.gmail.com>
	<5511787F.40301@redhat.com>
	<CAFEAcA8ZdnEweXL2R1JeR56t3P58QarFWbqSuv2i_E8zRtzquQ@mail.gmail.com>
	<55117DF5.7000408@redhat.com>
	<CAFEAcA901it8tZ33WL7t_w8AmmzBOn7E8vtGNXLFGAWHs-EOVw@mail.gmail.com>
	<1355384493.3824166.1427214234629.JavaMail.zimbra@redhat.com>
	<CAFEAcA8iYAHPcjdnsLk=U22pRJdb_fNeh+11Vj-GrCvBpCCZZA@mail.gmail.com>
	<5511A405.6090005@redhat.com>
	<CAFEAcA86KdfyzP3Jgj85=njFp8meAkyOf5qPL6miMy0MFnkxgQ@mail.gmail.com>
	<5511C251.8030907@redhat.com>
	<CAFEAcA_-rAmpzydwd20_f6gRJKQ8zHzEL=RUegNDnuQjYqEf3g@mail.gmail.com>
In-Reply-To: <CAFEAcA_-rAmpzydwd20_f6gRJKQ8zHzEL=RUegNDnuQjYqEf3g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] RFC: memory API changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Greg Bellows <greg.bellows@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>



On 25/03/2015 00:41, Peter Maydell wrote:
> On 24 March 2015 at 20:00, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> I agree with that.  I just want to keep ld/st*_phys _in addition_ as the
>> short forms of address_space_ld/st*, and keep ld/st*_phys instead of
>> address_space_ld/st* for those uses that have cs->as as the first argument.
> 
> ...but for ARM I want to be able to specify the memory
> attribute argument (and possibly also get the behaviour
> right on failure). So I definitely don't want the short
> forms for my cs->as uses.

You're free to move ARM to the longer versions, and/or to push the short
versions to all cpu.h files except ARM's.

> And it seems to me at best
> uncertain that anybody does, in the long run.

I disagree: most CPUs are in odd fixes/unmaintained state (so attributes
probably won't matter), and most don't even define an unassigned_access
callback (so result won't matter either).

>> The rationale is to evolve ld/st*_phys into CPU-specific accessors
>> paralleling the bus-specific accessors.
> 
> I don't think this is any harder starting from
> address_space_ld/st* than if we leave ld/st*_phys
> around.

It does cause unnecessary churn though.

Paolo