From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yajpe-0001ti-SA
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 07:50:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yajpa-0007a8-RX
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 07:50:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49193)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yajpa-0007Zb-Gb
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 07:50:42 -0400
Message-ID: <5512A107.10109@redhat.com>
Date: Wed, 25 Mar 2015 12:50:31 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAFEAcA-8AmagfK1NBE02J7kLEvVNdcm_oRbEmJpWAArL-2jc2Q@mail.gmail.com>
	<CAFEAcA8e3YwooQJHckMyuFO2yvDeDy73pj9LQ7Digj2DfzrUKQ@mail.gmail.com>
	<5511787F.40301@redhat.com>
	<CAFEAcA8ZdnEweXL2R1JeR56t3P58QarFWbqSuv2i_E8zRtzquQ@mail.gmail.com>
	<55117DF5.7000408@redhat.com>
	<CAFEAcA901it8tZ33WL7t_w8AmmzBOn7E8vtGNXLFGAWHs-EOVw@mail.gmail.com>
	<1355384493.3824166.1427214234629.JavaMail.zimbra@redhat.com>
	<CAFEAcA8iYAHPcjdnsLk=U22pRJdb_fNeh+11Vj-GrCvBpCCZZA@mail.gmail.com>
	<5511A405.6090005@redhat.com>
	<CAFEAcA86KdfyzP3Jgj85=njFp8meAkyOf5qPL6miMy0MFnkxgQ@mail.gmail.com>
	<5511C251.8030907@redhat.com>
	<CAFEAcA_-rAmpzydwd20_f6gRJKQ8zHzEL=RUegNDnuQjYqEf3g@mail.gmail.com>
	<55129D3D.60403@redhat.com>
	<CAFEAcA8FwC0C1MQfTU8hZQePN8WyJegEoj7J504zZiMDXmuSuQ@mail.gmail.com>
In-Reply-To: <CAFEAcA8FwC0C1MQfTU8hZQePN8WyJegEoj7J504zZiMDXmuSuQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] RFC: memory API changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Greg Bellows <greg.bellows@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>



On 25/03/2015 12:43, Peter Maydell wrote:
> I was trying to avoid leaving us with yet another half-finished
> set of API transitions: because many of our CPUs are in this
> odd-fixes state, it's unlikely anybody will get round to
> updating them in the near future, so we'll be carrying a
> duplicate set of functions around for a long time.

They're not duplicate, they're shortcuts.  Using longer function names
with more arguments is unnecessary if there's no need for the extra
features.

> If you insist I can leave the ldl_phys&c around as wrappers
> with a comment saying /* Do not use these in new code;
> use address_space_* instead. */,
> though.

I'll take care of changing the wrappers to take a CPUState instead of
AddressSpace, and move them to cpu.h.

If you convert ARM to address_space_*, ARM's cpu.h obviously won't get them.

Paolo