From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YakrB-0004Ce-9c
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 08:56:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Yakr6-0003CD-Kt
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 08:56:25 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5512B06A.8050502@redhat.com>
Date: Wed, 25 Mar 2015 13:56:10 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com>
In-Reply-To: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH COLO v2 00/13] Block replication for
	continuous checkpoints
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Lai Jiangshan <laijs@cn.fujitsu.com>, qemu block <qemu-block@nongnu.org>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>



On 25/03/2015 10:36, Wen Congyang wrote:
> Block replication is a very important feature which is used for
> continuous checkpoints(for example: COLO).
> 
> Usage:
> Please refer to docs/block-replication.txt
> 
> You can get the patch here:
> https://github.com/wencongyang/qemu-colo/commits/block-replication-v2
> 
> Changs Log:
> V2:
> 1. Redesign the secondary qemu(use image-fleecing)
> 2. Use Error objects to return error message
> 3. Address the comments from Max Reitz and Eric Blake
> 
> Wen Congyang (13):
>   docs: block replication's description
>   quorum: allow ignoring child errors
>   NBD client: connect to nbd server later
>   Add new block driver interfaces to control block replication
>   quorum: implement block driver interfaces for block replication
>   NBD client: implement block driver interfaces for block replication
>   allow writing to the backing file
>   Allow creating backup jobs when opening BDS
>   block: Parse "backing_reference" option to reference existing BDS
>   Backup: clear all bitmap when doing block checkpoint
>   qcow2: support colo
>   skip nbd_target when starting block replication
>   Don't allow a disk use backing reference target
> 
>  block.c                    | 242 +++++++++++++++++++++++-
>  block/Makefile.objs        |   2 +-
>  block/backup.c             |  12 ++
>  block/nbd.c                | 171 +++++++++++++++--
>  block/qcow2.c              | 447 ++++++++++++++++++++++++++++++++++++++++++++-
>  block/qcow2.h              |   6 +
>  block/quorum.c             | 143 ++++++++++++++-
>  docs/block-replication.txt | 147 +++++++++++++++
>  include/block/block.h      |   5 +
>  include/block/block_int.h  |  13 ++
>  include/qemu/hbitmap.h     |   8 +
>  qapi/block.json            |  16 ++
>  tests/qemu-iotests/051     |  13 ++
>  tests/qemu-iotests/051.out |  13 ++
>  util/hbitmap.c             |  19 ++
>  15 files changed, 1230 insertions(+), 27 deletions(-)
>  create mode 100644 docs/block-replication.txt
> 

Looks nice!

I've reviewed the patches where I'm competent.

Paolo