From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YalQs-0000GR-Ip for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:33:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YalQo-0008G5-EW for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:33:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YalQo-0008G1-6m for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:33:14 -0400 Message-ID: <5512B8FE.4040500@redhat.com> Date: Wed, 25 Mar 2015 14:32:46 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <5511ECD4.1030507@suse.de> <5512B6C3.2060005@imgtec.com> In-Reply-To: <5512B6C3.2060005@imgtec.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3] mips: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , =?UTF-8?B?RGlyayBNw7xsbGVy?= , qemu-devel@nongnu.org Cc: Stefan Weil , =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , Aurelien Jarno On 25/03/2015 14:23, Leon Alrae wrote: > On 24/03/2015 23:01, Andreas F=C3=A4rber wrote: >> Am 24.03.2015 um 22:28 schrieb Dirk M=C3=BCller: >>> Commit 0b183fc871:"memory: move mem_path handling to >>> memory_region_allocate_system_memory" split memory_region_init_ram an= d >>> memory_region_init_ram_from_file. Also it moved mem-path handling a s= tep >>> up from memory_region_init_ram to memory_region_allocate_system_memor= y. >>> >>> Therefore for any board that uses memory_region_init_ram directly, >>> -mem-path is not supported. >>> >>> Fix this by replacing memory_region_init_ram with >>> memory_region_allocate_system_memory. >>> >>> Signed-off-by: Dirk Mueller >>> --- >>> hw/mips/mips_fulong2e.c | 3 +-- >>> hw/mips/mips_jazz.c | 5 ++--- >>> hw/mips/mips_malta.c | 5 ++--- >>> hw/mips/mips_mipssim.c | 5 ++--- >>> hw/mips/mips_r4k.c | 3 +-- >>> 5 files changed, 8 insertions(+), 13 deletions(-) >> >> Reviewed-by: Andreas F=C3=A4rber >> >> Leon and Paolo, I assume one of you will be handling this? >> >=20 > Acked-by: Leon Alrae >=20 > Paolo, is this going via your memory API pullreq? I can include it since you've acked it. Paolo