From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <andreas.faerber@web.de>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Michael Walle <michael@walle.cc>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 for-2.3 1/5] hw: Mark devices picking up block backends actively FIXME
Date: Wed, 25 Mar 2015 16:18:56 +0100 [thread overview]
Message-ID: <5512D1E0.1030807@redhat.com> (raw)
In-Reply-To: <5512D18E.4010203@web.de>
On 25/03/2015 16:17, Andreas Färber wrote:
> > @@ -319,11 +319,13 @@ static void pc87312_realize(DeviceState *dev, Error **errp)
> > d = DEVICE(isa);
> > qdev_prop_set_uint32(d, "iobase", get_fdc_iobase(s));
> > qdev_prop_set_uint32(d, "irq", 6);
> > + /* FIXME use a qdev drive property instead of drive_get() */
> > drive = drive_get(IF_FLOPPY, 0, 0);
> > if (drive != NULL) {
> > qdev_prop_set_drive_nofail(d, "driveA",
> > blk_by_legacy_dinfo(drive));
> > }
> > + /* FIXME use a qdev drive property instead of drive_get() */
> > drive = drive_get(IF_FLOPPY, 0, 1);
> > if (drive != NULL) {
> > qdev_prop_set_drive_nofail(d, "driveB",
>
> As can be seen, there are drive properties driveA and driveB already on
> the destination device. How do you imagine this to be fixed? Add alias
> properties on the container device? (CC'ing Stefan)
Yes, creating the children in pc87312_isa and setting the properties on
pc87312 in the PReP board creation code.
Paolo
next prev parent reply other threads:[~2015-03-25 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 14:16 [Qemu-devel] [PATCH v2 for-2.3 0/5] Contain drive, serial, parallel, net misuse Markus Armbruster
2015-03-25 14:16 ` [Qemu-devel] [PATCH v2 for-2.3 1/5] hw: Mark devices picking up block backends actively FIXME Markus Armbruster
2015-03-25 15:17 ` Andreas Färber
2015-03-25 15:18 ` Paolo Bonzini [this message]
2015-03-25 14:16 ` [Qemu-devel] [PATCH v2 for-2.3 2/5] hw: Mark devices picking up char " Markus Armbruster
2015-03-25 15:23 ` Andreas Färber
2015-03-25 14:16 ` [Qemu-devel] [PATCH v2 for-2.3 3/5] hw: Mark device misusing nd_table[] FIXME Markus Armbruster
2015-03-25 14:16 ` [Qemu-devel] [PATCH v2 for-2.3 4/5] sdhci: Make device "sdhci-pci" unavailable with -device Markus Armbruster
2015-03-25 14:16 ` [Qemu-devel] [PATCH v2 for-2.3 5/5] sysbus: Make devices picking up backends " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5512D1E0.1030807@redhat.com \
--to=pbonzini@redhat.com \
--cc=andreas.faerber@web.de \
--cc=armbru@redhat.com \
--cc=michael@walle.cc \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).