From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yan5I-0005Vz-8C
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 11:19:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yan5F-00073i-1h
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 11:19:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37837)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yan5E-00073a-Ox
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 11:19:04 -0400
Message-ID: <5512D1E0.1030807@redhat.com>
Date: Wed, 25 Mar 2015 16:18:56 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1427292969-30929-1-git-send-email-armbru@redhat.com>
	<1427292969-30929-2-git-send-email-armbru@redhat.com>
	<5512D18E.4010203@web.de>
In-Reply-To: <5512D18E.4010203@web.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 for-2.3 1/5] hw: Mark devices picking up
 block backends actively FIXME
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Michael Walle <michael@walle.cc>, Stefan Hajnoczi <stefanha@redhat.com>



On 25/03/2015 16:17, Andreas F=C3=A4rber wrote:
> > @@ -319,11 +319,13 @@ static void pc87312_realize(DeviceState *dev, E=
rror **errp)
> >          d =3D DEVICE(isa);
> >          qdev_prop_set_uint32(d, "iobase", get_fdc_iobase(s));
> >          qdev_prop_set_uint32(d, "irq", 6);
> > +        /* FIXME use a qdev drive property instead of drive_get() */
> >          drive =3D drive_get(IF_FLOPPY, 0, 0);
> >          if (drive !=3D NULL) {
> >              qdev_prop_set_drive_nofail(d, "driveA",
> >                                         blk_by_legacy_dinfo(drive));
> >          }
> > +        /* FIXME use a qdev drive property instead of drive_get() */
> >          drive =3D drive_get(IF_FLOPPY, 0, 1);
> >          if (drive !=3D NULL) {
> >              qdev_prop_set_drive_nofail(d, "driveB",
>
> As can be seen, there are drive properties driveA and driveB already on
> the destination device. How do you imagine this to be fixed? Add alias
> properties on the container device? (CC'ing Stefan)

Yes, creating the children in pc87312_isa and setting the properties on
pc87312 in the PReP board creation code.

Paolo