From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YanPI-0002za-2w for qemu-devel@nongnu.org; Wed, 25 Mar 2015 11:39:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YanPC-0008Kz-Ue for qemu-devel@nongnu.org; Wed, 25 Mar 2015 11:39:47 -0400 Message-ID: <5512D6BC.8010300@mail.uni-paderborn.de> Date: Wed, 25 Mar 2015 16:39:40 +0100 From: Bastian Koppelmann MIME-Version: 1.0 References: <1426945498-29777-1-git-send-email-sw@weilnetz.de> <5512D220.2020303@msgid.tls.msk.ru> In-Reply-To: <5512D220.2020303@msgid.tls.msk.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-tricore: Fix check which was always false List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , Stefan Weil , QEMU Trivial Cc: QEMU Developer On 03/25/2015 04:20 PM, Michael Tokarev wrote: > 21.03.2015 16:44, Stefan Weil wrote: >> With a mask value of 0x00400000, the result will never be 1. >> This fixes a Coverity warning. > Might be a bit risky if the whole thing wasn't a complete no-op. > I wonder maybe the whole this if statement should be removed.. > > But anyway, applied to -trivial, thank you! > > /mjt > Thanks. The statement is just an indicator for a trap which needs to happen there. I'm working on this right now, so it won't stay like this for long :). Cheers, Bastian