From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YanTF-00062c-Bz for qemu-devel@nongnu.org; Wed, 25 Mar 2015 11:43:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YanT9-0001Z3-OI for qemu-devel@nongnu.org; Wed, 25 Mar 2015 11:43:53 -0400 Message-ID: <5512D79F.8040609@redhat.com> Date: Wed, 25 Mar 2015 09:43:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com> <1427276174-9130-5-git-send-email-wency@cn.fujitsu.com> <5512AE83.9060405@redhat.com> In-Reply-To: <5512AE83.9060405@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KWqw8NmUlJBWjCceAIGQ76i8xJGQ6xRtb" Subject: Re: [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Wen Congyang , qemu devel , Fam Zheng , Max Reitz Cc: Kevin Wolf , Lai Jiangshan , qemu block , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , Luiz Capitulino , Gonglei , Stefan Hajnoczi , Yang Hongyang , Michael Roth , zhanghailiang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KWqw8NmUlJBWjCceAIGQ76i8xJGQ6xRtb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/25/2015 06:48 AM, Paolo Bonzini wrote: >> ## >> +# @COLOMode >> +# >> +# An enumeration of COLO mode. s/mode/modes/ >> +# >> +# @unprotected: COLO is not started or after failover >> +# >> +# @primary: Primary mode, the vm's state will be sent to secondary QE= MU. Inconsistent on whether you end with '.' >> +# >> +# @secondary: Secondary mode, receive the vm's state from primary QEM= U. >> +# >> +# Since: 2.4 >> +## >> +{ 'enum' : 'COLOMode', >> + 'data' : ['unprotected', 'primary', 'secondary']} >=20 > Perhaps replace COLOMode with ReplicationMode or FaultToleranceMode? If you keep the name COLOMode, it would also be nice to spell out 'COurse-grain LOck-stepping' at least once somewhere in the .json file (probably in the description of this enum). A name like ReplicationMode is a bit more self-documenting (I know what replication is, I have to look up what COLO is). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KWqw8NmUlJBWjCceAIGQ76i8xJGQ6xRtb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVEtefAAoJEKeha0olJ0NqzyYIAIfgZj66ZqKP/TAmHzHEbaBF KUesOwxZz16Z+q8znjA13sSG0WO6v06uEp06egMRI8rzdkYXbmxP7kt8S2tNiWwa v8Uc+krzGcJzGUU6jp88iZDuPqE4+rzOwpWzoyrhZ8Z5myNqkJ2+99Fu3P8hMCXm /k9rtGR8CJ18KnSoG5Cs8rtGgHZrbcKvmmbCoer2tI7EyAt9dRufhWxkZfvDEFOf jn5LnNqtBWrn8bxBscg35huHNs/GbTwdCS86JAiaNEeKvFn0khmlp8guP/dujdGK 0ez3XfSpCo0aOd2f7H1xVukeBagvGpy8pX1dDWClcME7y7eM75Xh5gxY7KiGP6c= =TQSk -----END PGP SIGNATURE----- --KWqw8NmUlJBWjCceAIGQ76i8xJGQ6xRtb--