From: Eric Blake <eblake@redhat.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Lai Jiangshan <laijs@cn.fujitsu.com>,
quintela@redhat.com, GuiJianfeng@cn.fujitsu.com,
yunhong.jiang@intel.com, eddie.dong@intel.com,
dgilbert@redhat.com, mrhines@linux.vnet.ibm.com,
stefanha@redhat.com, Amit Shah <amit.shah@redhat.com>,
pbonzini@redhat.com, walid.nouri@gmail.com
Subject: Re: [Qemu-devel] [PATCH RESEND 1/2] Block: Block replication design for COLO
Date: Wed, 25 Mar 2015 10:11:12 -0600 [thread overview]
Message-ID: <5512DE20.60100@redhat.com> (raw)
In-Reply-To: <5512DD1D.9020704@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On 03/25/2015 10:06 AM, Eric Blake wrote:
> On 12/25/2014 08:31 PM, Yang Hongyang wrote:
>> This is the initial design of block replication.
>> The blkcolo block driver enables disk replication for continuous
>> checkpoints. It is designed for COLO that Secondary VM is running.
>> It can also be applied for FT/HA scene that Secondary VM is not
>> running.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>> ---
>> docs/blkcolo.txt | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 85 insertions(+)
>> create mode 100644 docs/blkcolo.txt
>
> Grammar review only (I'll leave the technical review to others)
Yikes; I replied to an old thread because I forgot to clear filtering on
my mail reader. Apologies for the noise, since...
>> +The blkcolo block driver enables disk replication for continuous checkpoints.
>> +It is designed for COLO that Secondary VM is running. It can also be applied
>
> similar comments as for Wen's RFC COLO v2 series for
> docs/block-replication.txt (in fact, do we need two files, or should all
> this information be merged into a single file?):
it looks like the patch I commented on has already been morphed into
newer versions.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-25 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 3:31 [Qemu-devel] [PATCH RESEND 0/2] PoC: Block replication for continuous checkpointing Yang Hongyang
2014-12-26 3:31 ` [Qemu-devel] [PATCH RESEND 1/2] Block: Block replication design for COLO Yang Hongyang
2015-03-25 16:06 ` Eric Blake
2015-03-25 16:11 ` Eric Blake [this message]
2014-12-26 3:31 ` [Qemu-devel] [PATCH RESEND 2/2] PoC: Block replication " Yang Hongyang
2014-12-27 15:23 ` [Qemu-devel] [PATCH RESEND 0/2] PoC: Block replication for continuous checkpointing Paolo Bonzini
2014-12-30 7:52 ` Hongyang Yang
2015-01-05 10:44 ` Dr. David Alan Gilbert
2015-01-06 1:28 ` Wen Congyang
2015-01-09 9:31 ` Hongyang Yang
2015-01-28 6:42 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5512DE20.60100@redhat.com \
--to=eblake@redhat.com \
--cc=GuiJianfeng@cn.fujitsu.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kwolf@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=walid.nouri@gmail.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).