From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yantv-00061q-WF for qemu-devel@nongnu.org; Wed, 25 Mar 2015 12:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yants-00040p-K6 for qemu-devel@nongnu.org; Wed, 25 Mar 2015 12:11:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yants-00040j-D0 for qemu-devel@nongnu.org; Wed, 25 Mar 2015 12:11:24 -0400 Message-ID: <5512DE20.60100@redhat.com> Date: Wed, 25 Mar 2015 10:11:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1419564708-17714-1-git-send-email-yanghy@cn.fujitsu.com> <1419564708-17714-2-git-send-email-yanghy@cn.fujitsu.com> <5512DD1D.9020704@redhat.com> In-Reply-To: <5512DD1D.9020704@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HpoKjxD9HG0Bto0Vv8GhHt4ELAIqB1Ngp" Subject: Re: [Qemu-devel] [PATCH RESEND 1/2] Block: Block replication design for COLO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Lai Jiangshan , quintela@redhat.com, GuiJianfeng@cn.fujitsu.com, yunhong.jiang@intel.com, eddie.dong@intel.com, dgilbert@redhat.com, mrhines@linux.vnet.ibm.com, stefanha@redhat.com, Amit Shah , pbonzini@redhat.com, walid.nouri@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HpoKjxD9HG0Bto0Vv8GhHt4ELAIqB1Ngp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/25/2015 10:06 AM, Eric Blake wrote: > On 12/25/2014 08:31 PM, Yang Hongyang wrote: >> This is the initial design of block replication. >> The blkcolo block driver enables disk replication for continuous >> checkpoints. It is designed for COLO that Secondary VM is running. >> It can also be applied for FT/HA scene that Secondary VM is not >> running. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: Lai Jiangshan >> Signed-off-by: Yang Hongyang >> --- >> docs/blkcolo.txt | 85 +++++++++++++++++++++++++++++++++++++++++++++++= +++++++++ >> 1 file changed, 85 insertions(+) >> create mode 100644 docs/blkcolo.txt >=20 > Grammar review only (I'll leave the technical review to others) Yikes; I replied to an old thread because I forgot to clear filtering on my mail reader. Apologies for the noise, since... >> +The blkcolo block driver enables disk replication for continuous chec= kpoints. >> +It is designed for COLO that Secondary VM is running. It can also be = applied >=20 > similar comments as for Wen's RFC COLO v2 series for > docs/block-replication.txt (in fact, do we need two files, or should al= l > this information be merged into a single file?): it looks like the patch I commented on has already been morphed into newer versions. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HpoKjxD9HG0Bto0Vv8GhHt4ELAIqB1Ngp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVEt4gAAoJEKeha0olJ0Nq1zoH/0vihZcpjE5IAkR3TvvZbaJB dAk0w8oDIiwQNIcc7gOWoh308ZMK7ZkDHrgoaqEH1PsPunZjnszZQ4bgIXNHcBof Dxlo+V3DFEw1HRp8QeLCJRzSut1apHOb8oREcothk+OiU0iooGsNfR8PNKsMvfAx M9ELOnMDgp4qC/9ZnWI+f6X/5cU7lcsJqp/rKK20UmBGJETq9bqaZNKQefWTceLw 7SIGiD6kpA82ZI+U5JfnjvPMY3kme2GIsqHoBLZnuVJh77XgLkQETdR6L0jJ6JGk 0XByCX1GMZC9/FqTmRA1eVAajIaIHkcnl24Tm2jN6B/tm4VrOlyfgUPIgatdo7I= =wWhQ -----END PGP SIGNATURE----- --HpoKjxD9HG0Bto0Vv8GhHt4ELAIqB1Ngp--