From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YavuF-0006Au-1t
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 20:44:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Yavu8-0002ds-95
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 20:44:18 -0400
Received: from mga03.intel.com ([134.134.136.65]:63107)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1Yavu8-0002da-2i
	for qemu-devel@nongnu.org; Wed, 25 Mar 2015 20:44:12 -0400
Message-ID: <55135658.3030904@intel.com>
Date: Thu, 26 Mar 2015 08:44:08 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1427073466-16956-1-git-send-email-tiejun.chen@intel.com>				
	<1427073466-16956-3-git-send-email-tiejun.chen@intel.com>				
	<55112498.2040108@intel.com>
	<1427190704.21742.318.camel@citrix.com>			
	<55113959.90600@intel.com>
	<1427192444.21742.330.camel@citrix.com>		
	<55113CFD.1040406@intel.com>
	<1427193616.21742.333.camel@citrix.com>	
	<55120CEA.2020607@intel.com> <1427279210.10784.49.camel@citrix.com>
In-Reply-To: <1427279210.10784.49.camel@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] One question to lowlevel/xl/xl.c and
	lowlevel/xc/xc.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Kevin <kevin.tian@intel.com>, wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com

On 2015/3/25 18:26, Ian Campbell wrote:
> On Wed, 2015-03-25 at 09:18 +0800, Chen, Tiejun wrote:
>> Actually my problem is that, I need to add a new parameter, 'flag', like
>> this, xc_assign_device(xxx,xxx,flag). So if I don't refine xc.c, tools
>> can't be compiled successfully. Or maybe you're suggesting I may isolate
>> this file while building tools, right?
>
> I answered this in my original reply:
>           it is acceptable for the new
>          parameter to not be plumbed up to the Python bindings until someone
>          comes along with a requirement to use it from Python. IOW you can just
>          pass whatever the nop value is for the new argument.
>

Yes, I knew this but I'm just getting a little confusion again after 
we're starting to talk if xc.c is compiled...

And I will try to do this.

> The "nop value" is whatever value should be passed to retain the current
> behaviour.

Sure.

Thanks
Tiejun