From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb6w2-0003Kv-UV for qemu-devel@nongnu.org; Thu, 26 Mar 2015 08:31:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb6w1-0008PI-KG for qemu-devel@nongnu.org; Thu, 26 Mar 2015 08:30:54 -0400 Message-ID: <5513FBF0.3010807@redhat.com> Date: Thu, 26 Mar 2015 06:30:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427276174-9130-1-git-send-email-wency@cn.fujitsu.com> <1427276174-9130-2-git-send-email-wency@cn.fujitsu.com> <5512D68F.5080504@redhat.com> <5513CA2B.6010403@cn.fujitsu.com> <5513DF5D.20106@huawei.com> In-Reply-To: <5513DF5D.20106@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XPj7D50mkFcrSnq9liGDJ27KUDKTIUUsc" Subject: Re: [Qemu-devel] [Qemu-block] [RFC PATCH COLO v2 01/13] docs: block replication's description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei , Wen Congyang , qemu devel , Fam Zheng , Max Reitz , Paolo Bonzini Cc: Lai Jiangshan , qemu block , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Yang Hongyang , zhanghailiang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XPj7D50mkFcrSnq9liGDJ27KUDKTIUUsc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/26/2015 04:28 AM, Gonglei wrote: >>>> Grammar review only (I'll leave the technical review to others) >>>> >>>>>> +Copyright Fujitsu, Corp. 2015 >>>>>> +Copyright (c) 2015 Intel Corporation >>>>>> +Copyright (c) 2015 HUAWEI TECHNOLOGIES CO.,LTD. >>>> >>>> Space after comma in English writing. >> Yes, but I am not sure I can change it. HUAWEI always use this way. Copyright lines are one thing that I am reluctant to change if it is not my own line (some companies have policies on how their lines must look, and I'm not in a position to argue the policy as I am not a lawyer). >> You can find it in bootdevice.c Such existing precedence is a strong argument to NOT changing it, at least for a patch author that is not the copyright owner. >=20 > Good catch, Eric is right. I will change all of this writing way in Qem= u at 2.4. So, sounds like such a change would be a separate patch (probably through the -trivial tree), and cover all files in the repo in one go, without affecting this series. Such a patch by a copyright owner would have no problem being accepted, if it is wanted. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XPj7D50mkFcrSnq9liGDJ27KUDKTIUUsc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVE/vwAAoJEKeha0olJ0NqdzEH/jeeuwmNqPcdjew4CmKkoKVd K2XQkSL3Ao29wKtqfxxRZP0mgIWmKIyhKDpR7x3S2ag8N0RIXgN20hmTldNrEnCb ZH8hGg+vpC6wo4lGP3GQKRNMOS4pCqfi62MY5woIDYhUkUgNCkDe7Ak1Favv+qL/ s46bTn+hX2lzVAy+TbAJhGCmjbs0ChH09eAp5yigd6YiJKTZrKkloTQnMdVThBky 3RpiSMsK/gPn4mdctTRqkgVOoXW3Wo4WxaitE4P6biUwfpnFWQS6GTNIHxlPg/zp Wlqm/L/cBLk5FUcpDlOv85SbEtK6OFypR9j+HfksDKufmIKenfyEo3/AqKRyCWA= =gUJ9 -----END PGP SIGNATURE----- --XPj7D50mkFcrSnq9liGDJ27KUDKTIUUsc--