From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb7cr-00043c-T5 for qemu-devel@nongnu.org; Thu, 26 Mar 2015 09:15:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb7cn-0004u7-TU for qemu-devel@nongnu.org; Thu, 26 Mar 2015 09:15:09 -0400 Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:35311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb7cn-0004o2-Ni for qemu-devel@nongnu.org; Thu, 26 Mar 2015 09:15:05 -0400 Received: by wgdm6 with SMTP id m6so63924843wgd.2 for ; Thu, 26 Mar 2015 06:15:04 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55140653.30202@redhat.com> Date: Thu, 26 Mar 2015 14:14:59 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1427338992-27057-1-git-send-email-famz@redhat.com> <20150326125332.GA3932@noname.redhat.com> In-Reply-To: <20150326125332.GA3932@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: Add support for tcmalloc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Fam Zheng Cc: Peter Maydell , qemu-devel@nongnu.org, Stefan Hajnoczi On 26/03/2015 13:53, Kevin Wolf wrote: > Am 26.03.2015 um 04:03 hat Fam Zheng geschrieben: >> This adds "--enable-tcmalloc" and "--disable-tcmalloc" to allow linking >> to libtcmalloc from gperftools. >> >> tcmalloc is a malloc implementation that works well with threads and is >> fast, so it is good for performance. >> >> It is disabled by default, because the MALLOC_PERTURB_ flag we use in >> tests doesn't work with tcmalloc. However we can enable tcmalloc >> specific heap checker and profilers later. >> >> An IOPS gain can be observed with virtio-blk-dataplane, other parts of >> QEMU will directly benefit from it as well: >> >> ========================================================== >> glibc malloc >> ---------------------------------------------------------- >> rw bs iodepth bw iops latency >> read 4k 1 150 38511 24 >> ---------------------------------------------------------- >> >> ========================================================== >> tcmalloc >> ---------------------------------------------------------- >> rw bs iodepth bw iops latency >> read 4k 1 156 39969 23 >> ---------------------------------------------------------- >> >> Signed-off-by: Fam Zheng >> --- >> configure | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/configure b/configure >> index 589798e..03ba305 100755 >> --- a/configure >> +++ b/configure >> @@ -336,6 +336,7 @@ libssh2="" >> vhdx="" >> quorum="" >> numa="" >> +tcmalloc="no" >> >> # parse CC options first >> for opt do >> @@ -1134,6 +1135,10 @@ for opt do >> ;; >> --enable-numa) numa="yes" >> ;; >> + --disable-tcmalloc) tcmalloc="no" >> + ;; >> + --enable-tcmalloc) tcmalloc="yes" >> + ;; >> *) >> echo "ERROR: unknown option $opt" >> echo "Try '$0 --help' for more information" >> @@ -1407,6 +1412,8 @@ Advanced options (experts only): >> --enable-quorum enable quorum block filter support >> --disable-numa disable libnuma support >> --enable-numa enable libnuma support >> + --disable-tcmalloc disable tcmalloc support >> + --enable-numa enable tcmalloc support > > Almost. :-) Will fix and apply for 2.4. Paolo