From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb8Cc-0000fR-34 for qemu-devel@nongnu.org; Thu, 26 Mar 2015 09:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb8CV-0001to-Fg for qemu-devel@nongnu.org; Thu, 26 Mar 2015 09:52:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb8CV-0001ti-A8 for qemu-devel@nongnu.org; Thu, 26 Mar 2015 09:51:59 -0400 Message-ID: <55140EFD.805@redhat.com> Date: Thu, 26 Mar 2015 07:51:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-7-git-send-email-eblake@redhat.com> <87a8yz51uc.fsf@blackfin.pond.sub.org> In-Reply-To: <87a8yz51uc.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7OA5wCMs1HJcouqNCrjeLXLeb9HhbfaOi" Subject: Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7OA5wCMs1HJcouqNCrjeLXLeb9HhbfaOi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/26/2015 07:23 AM, Markus Armbruster wrote: > One more: >=20 > [...] >> diff --git a/tests/qapi-schema/alternate-conflict-string.json b/tests/= qapi-schema/alternate-conflict-string.json >> new file mode 100644 >> index 0000000..5fd1a47 >> --- /dev/null >> +++ b/tests/qapi-schema/alternate-conflict-string.json >> @@ -0,0 +1,8 @@ >> +# FIXME: we should reject anonymous unions with multiple string-like = branches >> +{ 'enum': 'Enum', >> + 'data': [ 'hello', 'world' ] } >> +{ 'union': 'MyUnion', >> + 'discriminator': {}, >> + 'data': { 'one': 'str', >> + 'two': 'Enum' } } >> + >=20 > /home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line at E= OF. Huh. I thought I had git set up to reject me from making commits like that locally, but obviously not. http://wiki.qemu.org/Contribute/SubmitAPatch should probably mention the magic one-time setup to use to turn this type of checking on... --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7OA5wCMs1HJcouqNCrjeLXLeb9HhbfaOi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVFA79AAoJEKeha0olJ0NqpSQH/3r9kDCwVtFc3iOP6VY0lXd5 Xg4DUmPLiOmWGi2PERvWXlhoCmcQLu/oUbd93Xc/b1g33mF8CEzHINjilnLZ59j9 1I2fYscUNnsAhT/yoQrwp6Fqjd4IPddCXI/bJIJHdRdKTgb3FtYF0Vh/+fiVEQvU a5Z+YcQ+BgATwI3bzBXA3xALdL+5fd4/NcxTgH6wnbO8nnNr6ZIS8fMq7aihATaT DAHeXEKqSwSC3ZLgE2cuGuzkYfx4kqUIJFv4+XXPHXXaEljn2lNxpnzJZIoYrdl1 YaSi8q6Pf79Xo4yx0S9R2MIOKdsQACmIESEr1e/i1ZzRCyzrtZR8RrcmtfWrI1I= =HWtp -----END PGP SIGNATURE----- --7OA5wCMs1HJcouqNCrjeLXLeb9HhbfaOi--