From: Paolo Bonzini <pbonzini@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>, Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
qemu block <qemu-block@nongnu.org>, Jeff Cody <jcody@redhat.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu devel <qemu-devel@nongnu.org>,
Gonglei <arei.gonglei@huawei.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS
Date: Thu, 26 Mar 2015 14:53:52 +0100 [thread overview]
Message-ID: <55140F70.1030009@redhat.com> (raw)
In-Reply-To: <5513B40A.4050104@cn.fujitsu.com>
On 26/03/2015 08:23, Wen Congyang wrote:
>>> >> Hmm, we need to use backup API in block.c, and block.o will
>>> >> be used by qemu-img which doesn't use common-obj.
>> >
>> > I see. How about adding the referenced functions to stubs/?
> Good idea. I will try it.
Even better would be to move the functions that need backup APIs to
another file. block.c is big, and it is going to be split soon into
multiple files.
Paolo
next prev parent reply other threads:[~2015-03-26 13:54 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 9:36 [Qemu-devel] [RFC PATCH COLO v2 00/13] Block replication for continuous checkpoints Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 01/13] docs: block replication's description Wen Congyang
2015-03-25 15:38 ` [Qemu-devel] [Qemu-block] " Eric Blake
2015-03-26 8:58 ` Wen Congyang
2015-03-26 10:28 ` Gonglei
2015-03-26 12:30 ` Eric Blake
2015-03-26 12:46 ` Gonglei
2015-03-26 6:31 ` [Qemu-devel] " Fam Zheng
2015-03-26 7:17 ` Wen Congyang
2015-04-03 2:35 ` Wen Congyang
2015-04-03 5:19 ` Fam Zheng
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 02/13] quorum: allow ignoring child errors Wen Congyang
2015-03-25 12:45 ` Paolo Bonzini
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 03/13] NBD client: connect to nbd server later Wen Congyang
2015-03-25 12:46 ` Paolo Bonzini
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 04/13] Add new block driver interfaces to control block replication Wen Congyang
2015-03-25 12:48 ` Paolo Bonzini
2015-03-25 15:43 ` Eric Blake
2015-03-26 7:12 ` Fam Zheng
2015-03-26 7:22 ` Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 05/13] quorum: implement block driver interfaces for " Wen Congyang
2015-03-25 12:50 ` Paolo Bonzini
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 06/13] NBD client: " Wen Congyang
2015-03-25 12:50 ` Paolo Bonzini
2015-03-26 7:21 ` Fam Zheng
2015-03-26 7:32 ` Wen Congyang
2015-03-27 1:06 ` Fam Zheng
2015-03-27 1:16 ` Wen Congyang
2015-03-27 7:34 ` [Qemu-devel] Use of QERR_ macros and error classes (was: [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication) Markus Armbruster
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 07/13] allow writing to the backing file Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 08/13] Allow creating backup jobs when opening BDS Wen Congyang
2015-03-26 7:07 ` Fam Zheng
2015-03-26 7:14 ` Wen Congyang
2015-03-26 7:18 ` Fam Zheng
2015-03-26 7:23 ` Wen Congyang
2015-03-26 13:53 ` Paolo Bonzini [this message]
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 09/13] block: Parse "backing_reference" option to reference existing BDS Wen Congyang
2015-03-26 7:31 ` Fam Zheng
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 10/13] Backup: clear all bitmap when doing block checkpoint Wen Congyang
2015-03-25 12:55 ` Paolo Bonzini
2015-03-26 0:59 ` Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 11/13] qcow2: support colo Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 12/13] skip nbd_target when starting block replication Wen Congyang
2015-03-26 7:03 ` Fam Zheng
2015-03-26 7:15 ` Wen Congyang
2015-03-25 9:36 ` [Qemu-devel] [RFC PATCH COLO v2 13/13] Don't allow a disk use backing reference target Wen Congyang
2015-03-25 12:56 ` [Qemu-devel] [RFC PATCH COLO v2 00/13] Block replication for continuous checkpoints Paolo Bonzini
2015-03-25 14:24 ` Dr. David Alan Gilbert
2015-03-26 2:34 ` Gonglei
2015-07-01 3:09 ` Michael R. Hines
2015-07-01 4:11 ` Wen Congyang
2015-07-01 19:30 ` Michael R. Hines
2015-07-01 19:37 ` Michael R. Hines
2015-07-02 0:58 ` Wen Congyang
2015-07-02 1:43 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55140F70.1030009@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).