From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: lma@suse.com, afaerber@suse.de, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] fix assertion in "info memory-devices" if memdev isn't accessible
Date: Thu, 26 Mar 2015 21:33:19 +0100 [thread overview]
Message-ID: <55146D0F.6040309@redhat.com> (raw)
In-Reply-To: <1427388174-30915-1-git-send-email-imammedo@redhat.com>
On 26/03/2015 17:42, Igor Mammedov wrote:
> + mdevid = object_property_get_str(OBJECT(dimm->hostmem), "id",
> + &error_abort);
> + mdevpath = g_strdup_printf("/objects/%s", mdevid);
> + g_free(mdevid);
> + mdev = object_resolve_path_type(mdevpath, TYPE_MEMORY_BACKEND,
> + NULL);
You can add a backend with id xyz, remove it, and add another with the
same id, right?
I think the can_be_deleted solution is better and not more invasive,
even for 2.3.
Paolo
next prev parent reply other threads:[~2015-03-26 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 16:42 [Qemu-devel] [PATCH] fix assertion in "info memory-devices" if memdev isn't accessible Igor Mammedov
2015-03-26 19:59 ` Luiz Capitulino
2015-03-26 20:26 ` Luiz Capitulino
2015-03-27 14:20 ` Igor Mammedov
2015-03-26 20:33 ` Paolo Bonzini [this message]
2015-03-27 14:18 ` Igor Mammedov
2015-03-27 14:24 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55146D0F.6040309@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lma@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).