From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbEtP-00034a-Hm for qemu-devel@nongnu.org; Thu, 26 Mar 2015 17:00:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbEtK-00054Y-Jw for qemu-devel@nongnu.org; Thu, 26 Mar 2015 17:00:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbEtK-00054L-EW for qemu-devel@nongnu.org; Thu, 26 Mar 2015 17:00:38 -0400 Message-ID: <5514736F.3040605@redhat.com> Date: Thu, 26 Mar 2015 22:00:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <6C5ABA02-5765-47C0-B9C6-72C8F461F469@gmail.com> <55146CBB.2050406@ilande.co.uk> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-discuss] error - Guest has not initialized the display yet. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Mark Cave-Ayland Cc: Peter Crosthwaite , Programmingkid , anandk1386@gmail.com, qemu-devel qemu-devel On 26/03/2015 21:55, Peter Maydell wrote: > I feel like we're recapitulating history here -- is > c3c1bb99d undoing the fix that a87f39543a made for when we > tried this a year ago in 360e607, or is there something > more subtle going on ? It's more subtle. The patch should only make a difference when address_space_translate_internal modifies *plen. The crux of the change is the first operand of this MIN: - len = MIN(len, (addr | iotlb.addr_mask) - addr + 1); + *plen = MIN(*plen, (addr | iotlb.addr_mask) - addr + 1); changing from len to *plen. Paolo