From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34330)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YbJ5p-0001gL-0Q
	for qemu-devel@nongnu.org; Thu, 26 Mar 2015 21:29:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YbJ5j-0007TH-Ql
	for qemu-devel@nongnu.org; Thu, 26 Mar 2015 21:29:48 -0400
Received: from mga02.intel.com ([134.134.136.20]:64640)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YbJ5j-0007S5-Kn
	for qemu-devel@nongnu.org; Thu, 26 Mar 2015 21:29:43 -0400
Message-ID: <5514B281.1050301@intel.com>
Date: Fri, 27 Mar 2015 09:29:37 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1427073466-16956-1-git-send-email-tiejun.chen@intel.com>			
	<1427073466-16956-3-git-send-email-tiejun.chen@intel.com>		
	<1427208618.21742.421.camel@citrix.com>
	<55120B1C.5080004@intel.com>	
	<1427279543.10784.53.camel@citrix.com> <551358A7.2090607@intel.com>
	<1427364418.10784.122.camel@citrix.com>
In-Reply-To: <1427364418.10784.122.camel@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com, qemu-devel@nongnu.org, stefano.stabellini@citrix.com, xen-devel@lists.xen.org

On 2015/3/26 18:06, Ian Campbell wrote:
> On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote:
>>> Hrm, OK. I suppose we can live with autodetect and igd both meaning igd
>>> and whoever adds a new type will have to remember to add a check for
>>> qemu-trad then.
>>>
>>
>> When we really have to introduce a new type, this means we probably need
>> to change something inside qemu codes. So a new type should just go into
>> that table to support qemu upstream since now we shouldn't refactor
>> anything in qemu-xen-traditional, right?
>
> We'd want to error out on attempts to use qemu-xen-trad with non-IGD
> passthru.
>

On qemu-xen-traditional side, we always recognize this as BOOLEAN,

         if (libxl_defbool_val(b_info->u.hvm.gfx_passthru)) { 

             flexarray_append(dm_args, "-gfx_passthru"); 

         }

Additionally, this is also clarified explicitly in manpage, and 
especially we don't change this behavior now, so I'm just wondering why 
we should do this :)

Thanks
Tiejun