From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybau9-0007WJ-OQ for qemu-devel@nongnu.org; Fri, 27 Mar 2015 16:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ybau4-0006BC-4j for qemu-devel@nongnu.org; Fri, 27 Mar 2015 16:30:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybau3-0006Az-LD for qemu-devel@nongnu.org; Fri, 27 Mar 2015 16:30:52 -0400 Message-ID: <5515BDF8.1060109@redhat.com> Date: Fri, 27 Mar 2015 14:30:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-25-git-send-email-eblake@redhat.com> <87lhiircm2.fsf@blackfin.pond.sub.org> In-Reply-To: <87lhiircm2.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6v2UP30Xs0sTfPS4femawcCoHblmfo6FO" Subject: Re: [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6v2UP30Xs0sTfPS4femawcCoHblmfo6FO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/27/2015 03:52 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> In the testsuite, UserDefTwo and UserDefNested were identical >> types other than the member names. Reduce code duplication by >> having just one type, and choose names that also favor reuse. >> This will also make it easier for a later patch to get rid of >> inline nested types in QAPI; it means that the type is now boxed >> instead of unboxed in C code, but has no difference to the QMP >> wire protocol. >=20 > I can't see a change from boxed to unboxed in this patch. Does the > remark apply to the elimination of nested types? If yes, it's prematur= e > here. May be a stale comment; either as the result of too much copy-and-paste between similar patches 25 and 26, or as the result of begin first written last September and several of your tree cleanups hitting the git repo in the meantime. I'll clean up the commit wording in v6. >=20 >> When touching code to add new allocations, also >> convert existing allocations to consistently prefer typesafe >> g_new0 over g_malloc0. >=20 > I can't see any change from g_malloc0() to g_new0(). Is this stale? >=20 >> >> Ensure that 'make check-qapi-schema check-unit' still passes. >> >> Signed-off-by: Eric Blake >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6v2UP30Xs0sTfPS4femawcCoHblmfo6FO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVFb34AAoJEKeha0olJ0Nq6JgH/jwEc2/BmGFMQ4zbSa93E5Qu 34zzWAazKmRd+RXWvXYrLmnNqifWugCm5DzPybsPWWxnrZ6Zeo0l4nt0cSfDjVN7 UkwfYArTO69fsa9yH0GD9aumZvNt0A2TKOla7aSMbtYOw3h/NJSVx/l0LioNsMCA +je3EXDMqCe6Hfc4LRYyZcNSpDQj0DI7navFK9VQLhiKpvpjVlEqQSIQhRm1rFZx qolqwHAavEAUK+eGj1jaWrCjjgdXNRk1PqACOSDDHLyF+dBIJKDXotU7XP3LfFqF 7GKCNhBtjeJJ2P5kI7X3Ecz42UmaHPAky5v/qRmynpd20UO8HGw0Xy5wopdb9v0= =Ima6 -----END PGP SIGNATURE----- --6v2UP30Xs0sTfPS4femawcCoHblmfo6FO--