From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3853ECA1009 for ; Wed, 3 Sep 2025 12:32:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utmex-0000oo-SO; Wed, 03 Sep 2025 08:32:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utmef-0000Pz-KW for qemu-devel@nongnu.org; Wed, 03 Sep 2025 08:32:10 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1utmed-0002Kc-Jh for qemu-devel@nongnu.org; Wed, 03 Sep 2025 08:32:01 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-6188b72b7caso7004880a12.2 for ; Wed, 03 Sep 2025 05:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756902717; x=1757507517; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QkGNhaavMYjz7UsHtnl5vmsVCeeBUAF/p6qVuFMYOBY=; b=yoOekAXyN+LHxRw+Gg8LwKLGpFHAr6fYcqlAkr0wLCimUxyWYFVDC3ccGa1J9kj6q+ anyP/f1L6G+txSIuz7EmVrRzz4ssI2rOxhpAvA8YaACPFhtVKXgm4IvgofZfOjd9cAyX 4YIvdNiqx5oUnZyMx1fOn5QyTz68J0r/7YnwqeVhF04Reoe+Qu6GlAdwnpC7CRihsEH3 1tPcTnIxN4hj8DLZR7dxU4pY5hcbHzaVQ2fhtTODCYhKyVw82ylaJKtY/rCSUEnLKzTa DfFkDsUsiwouZsZz29Hts9zZX9SPokXmn+VwVvMuPsLaZP64ospjExp2/sg7WCVBbarh 5QmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756902717; x=1757507517; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QkGNhaavMYjz7UsHtnl5vmsVCeeBUAF/p6qVuFMYOBY=; b=Jqj1IChm+uNYvqmFS1TQfhJo1SBQiS33zTWKHezjvqI4V2uBy6f/ddmgkxHuGvKATZ wJ42y99ra5c1y0aq0q6QIWXcJG+Js3Tv439QahLY0JVgvaN17iXgutluvYRiI9MXnJCI jnrrWJXk23y1tBdeq2E6jc/7uI0BOrjvdAMWTzrf+bcJNBiQ6cbkEelgSpSrKhSpffm5 1LGSGamQNsd8a+RfFDBIKurhi83w+JUl+8qk1oPCZBgyw9Sexh+uKzJfd9a+ugH5uSdk DXi5AtAQewWLpBlWEFa7nkXh8mZy0xGUVRYzsdk9mFjUnu4Llc0I8EI8kh5DRYlapp4X 1O9g== X-Forwarded-Encrypted: i=1; AJvYcCWV/hxzFTlnap8o9pT5/A9kZQaOIlgSkA4Y0Y8oLRl2orvj9pW5WuVpMB0Usi23vvc/qkdnNeOJ2Q4i@nongnu.org X-Gm-Message-State: AOJu0YzlHxYSyt7AX5rffMwXRbL5XPv8oeKU1k+gNCUrqX6Juf31ZWPw dXrNf4+RrcLiQjBCQ4sf6rG4LQNK44Bd73PculD6lJ14Ozmeg9W93WB/qCChVoI3HQM= X-Gm-Gg: ASbGnctceb3OY6zxpKkgGCnl5pLhsqTRENPCnvN8+4nRk3bPk49q/Lpk5tylh18wSvd dxPdIgi4NWUepXuw52Nkh77nDXTOddeiKojfA8IKrsAkD6d3RYWnUZfotj5oeeEudtrCciwCAdK xjO8WlTRDffamKvygBP+Su27Vu+nHu5ikVyLY2q8ZwGLET6hsH+sgs4Qqd5gbiD7wclOSFjowpt B66Epj2XM1gTNBMfCcahJOxhab/nwT7ybxN34tvlzzhqzs3/JjOxJsq0TVk1uJ5bIIzpjdoz1SI 02hiPHVNuV23tbPTbIDJoibcqBt1zvidQpye8C3KB2eiVEuo7yOtfToMH69OxWUrkVEtnUYLvF3 zrrJafv+5VjJzQkTf+lJfPkXDjyMJa8KdD3ismpnjq/oCepAi2RuQLGtDqrlO6hKx3VYZT9lv1B qFo4dydw== X-Google-Smtp-Source: AGHT+IHY5svnQWkQk08KMVwPb/m5FH9iRcjKkI0JnwdAD8kBZ9GMhj6OMl3cpThmzXyPzWHuMg5yDw== X-Received: by 2002:a05:6402:2547:b0:61d:1188:42d2 with SMTP id 4fb4d7f45d1cf-61d26da5e53mr13897656a12.28.1756902716701; Wed, 03 Sep 2025 05:31:56 -0700 (PDT) Received: from [10.40.6.207] (93-51-222-138.ip268.fastwebnet.it. [93.51.222.138]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61cfc1c77d0sm12002829a12.11.2025.09.03.05.31.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Sep 2025 05:31:56 -0700 (PDT) Message-ID: <5516c865-2315-494d-9bf2-ad7b50f5289b@linaro.org> Date: Wed, 3 Sep 2025 14:31:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/24] target/arm/hvf: Mention flush_cpu_state() must run on vCPU thread To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Alexander Graf , qemu-arm@nongnu.org, Mohamed Mediouni , Peter Maydell , Mads Ynddal , Phil Dennis-Jordan , Stefan Hajnoczi , Cameron Esfahani , Roman Bolshakov , Paolo Bonzini References: <20250903100702.16726-1-philmd@linaro.org> <20250903100702.16726-7-philmd@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250903100702.16726-7-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/3/25 12:06, Philippe Mathieu-Daudé wrote: > Since flush_cpu_state() calls hvf_arch_put_registers(), > which must run on a vCPU, it also must. Mention it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/hvf/hvf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c > index 21002f419f5..58934953c4a 100644 > --- a/target/arm/hvf/hvf.c > +++ b/target/arm/hvf/hvf.c > @@ -814,6 +814,7 @@ int hvf_arch_put_registers(CPUState *cpu) > return 0; > } > > +/* Must be called by the owning thread */ > static void flush_cpu_state(CPUState *cpu) > { > if (cpu->vcpu_dirty) { Reviewed-by: Richard Henderson r~