From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcOkY-0000Mu-VM for qemu-devel@nongnu.org; Sun, 29 Mar 2015 21:44:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcOkY-00022X-1N for qemu-devel@nongnu.org; Sun, 29 Mar 2015 21:44:22 -0400 Message-ID: <5518AA4F.2020005@huawei.com> Date: Mon, 30 Mar 2015 09:43:43 +0800 From: Gonglei MIME-Version: 1.0 References: <1427649571-4497-1-git-send-email-afaerber@suse.de> In-Reply-To: <1427649571-4497-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-2.3?] qom: Fix object_property_add_alias() with [*] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-stable , "Michael S. Tsirkin" On 2015/3/30 1:19, Andreas Färber wrote: > Commit 8074264 (qom: Add description field in ObjectProperty struct) > introduced property descriptions and copied them for alias properties. > > Instead of using the caller-supplied property name, use the returned > property name for setting the description. This avoids an Error when > setting a property description for a property with literal "[*]" that > doesn't exist due to automatic property naming in object_property_add(). > > Cc: Gonglei > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Signed-off-by: Andreas Färber > --- > qom/object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qom/object.c b/qom/object.c > index d167038..b8dff43 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -1761,7 +1761,7 @@ void object_property_add_alias(Object *obj, const char *name, > } > op->resolve = property_resolve_alias; > > - object_property_set_description(obj, name, > + object_property_set_description(obj, op->name, > target_prop->description, > &error_abort); > Looks good to me. I think this is a candidate for 2.3 rc2. Cc: qemu-stable Reviewed-by: Gonglei Regards, -Gonglei