From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcUSe-0001KK-3z for qemu-devel@nongnu.org; Mon, 30 Mar 2015 03:50:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcUSc-0005G9-Pb for qemu-devel@nongnu.org; Mon, 30 Mar 2015 03:50:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcUSc-0005Fr-HP for qemu-devel@nongnu.org; Mon, 30 Mar 2015 03:50:14 -0400 Message-ID: <5519002E.3020301@redhat.com> Date: Mon, 30 Mar 2015 09:50:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427649571-4497-1-git-send-email-afaerber@suse.de> In-Reply-To: <1427649571-4497-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3?] qom: Fix object_property_add_alias() with [*] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Gonglei , "Michael S. Tsirkin" On 29/03/2015 19:19, Andreas F=C3=A4rber wrote: > Commit 8074264 (qom: Add description field in ObjectProperty struct) > introduced property descriptions and copied them for alias properties. >=20 > Instead of using the caller-supplied property name, use the returned > property name for setting the description. This avoids an Error when > setting a property description for a property with literal "[*]" that > doesn't exist due to automatic property naming in object_property_add(). >=20 > Cc: Gonglei > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Signed-off-by: Andreas F=C3=A4rber > --- > qom/object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/qom/object.c b/qom/object.c > index d167038..b8dff43 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -1761,7 +1761,7 @@ void object_property_add_alias(Object *obj, const= char *name, > } > op->resolve =3D property_resolve_alias; > =20 > - object_property_set_description(obj, name, > + object_property_set_description(obj, op->name, > target_prop->description, > &error_abort); > =20 >=20 Acked-by: Paolo Bonzini