From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp,
quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com,
yanghy@cn.fujitsu.com
Subject: Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread
Date: Mon, 30 Mar 2015 10:31:06 +0200 [thread overview]
Message-ID: <551909CA.7080605@redhat.com> (raw)
In-Reply-To: <20150326110517.GA2370@work-vm>
On 26/03/2015 12:05, Dr. David Alan Gilbert wrote:
>>> > > + qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER);
>>> > > + *old_vm_running = runstate_is_running();
>> >
>> > I think that needs some explanation. Why are you doing a wakeup on
>> > the source host?
> This matches the existing code in migration_thread for the end of precopy;
> Paolo's explanation of what it does is here:
> https://lists.gnu.org/archive/html/qemu-devel/2014-08/msg04880.html
The more I look at it, the more I'm convinced it's working by chance or
not working at all.
Here we probably need to do only the notifier_list_notify +
qapi_event_send_wakeup.
Paolo
next prev parent reply other threads:[~2015-03-30 8:31 UTC|newest]
Thread overview: 181+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 16:51 [Qemu-devel] [PATCH v5 00/45] Postcopy implementation Dr. David Alan Gilbert (git)
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 01/45] Start documenting how postcopy works Dr. David Alan Gilbert (git)
2015-03-05 3:21 ` David Gibson
2015-03-05 9:21 ` Dr. David Alan Gilbert
2015-03-10 1:04 ` David Gibson
2015-03-13 13:07 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 02/45] Split header writing out of qemu_save_state_begin Dr. David Alan Gilbert (git)
2015-03-10 1:05 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 03/45] qemu_ram_foreach_block: pass up error value, and down the ramblock name Dr. David Alan Gilbert (git)
2015-03-10 15:30 ` Eric Blake
2015-03-10 16:21 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 04/45] Add qemu_get_counted_string to read a string prefixed by a count byte Dr. David Alan Gilbert (git)
2015-03-10 1:12 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 05/45] Create MigrationIncomingState Dr. David Alan Gilbert (git)
2015-03-10 2:37 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 06/45] Provide runtime Target page information Dr. David Alan Gilbert (git)
2015-03-10 2:38 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 07/45] Return path: Open a return path on QEMUFile for sockets Dr. David Alan Gilbert (git)
2015-03-10 2:49 ` David Gibson
2015-03-13 13:14 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 08/45] Return path: socket_writev_buffer: Block even on non-blocking fd's Dr. David Alan Gilbert (git)
2015-03-10 2:56 ` David Gibson
2015-03-10 13:35 ` Dr. David Alan Gilbert
2015-03-11 1:51 ` David Gibson
2015-03-28 15:30 ` Paolo Bonzini
2015-03-29 4:07 ` David Gibson
2015-03-29 9:03 ` Paolo Bonzini
2015-03-30 16:50 ` Dr. David Alan Gilbert
2015-03-30 18:22 ` Markus Armbruster
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 09/45] Migration commands Dr. David Alan Gilbert (git)
2015-03-10 4:58 ` David Gibson
2015-03-10 11:04 ` Dr. David Alan Gilbert
2015-03-10 11:06 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 10/45] Return path: Control commands Dr. David Alan Gilbert (git)
2015-03-10 5:40 ` David Gibson
2015-03-28 15:32 ` Paolo Bonzini
2015-03-30 17:34 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source Dr. David Alan Gilbert (git)
2015-03-10 5:47 ` David Gibson
2015-03-10 14:34 ` Dr. David Alan Gilbert
2015-03-11 1:54 ` David Gibson
2015-03-25 18:47 ` Dr. David Alan Gilbert
2015-03-28 15:34 ` Paolo Bonzini
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 12/45] Return path: Source handling of return path Dr. David Alan Gilbert (git)
2015-03-10 6:08 ` David Gibson
2015-03-20 18:17 ` Dr. David Alan Gilbert
2015-03-23 2:37 ` David Gibson
2015-04-01 15:14 ` Dr. David Alan Gilbert
2015-04-07 3:07 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 13/45] ram_debug_dump_bitmap: Dump a migration bitmap as text Dr. David Alan Gilbert (git)
2015-03-10 6:11 ` David Gibson
2015-03-20 18:48 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 14/45] Move loadvm_handlers into MigrationIncomingState Dr. David Alan Gilbert (git)
2015-03-10 6:19 ` David Gibson
2015-03-10 10:12 ` Dr. David Alan Gilbert
2015-03-10 11:03 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 15/45] Rework loadvm path for subloops Dr. David Alan Gilbert (git)
2015-03-12 6:11 ` David Gibson
2015-04-14 12:04 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 16/45] Add migration-capability boolean for postcopy-ram Dr. David Alan Gilbert (git)
2015-03-12 6:14 ` David Gibson
2015-03-13 12:58 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 17/45] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages Dr. David Alan Gilbert (git)
2015-03-12 9:30 ` David Gibson
2015-03-26 16:33 ` Dr. David Alan Gilbert
2015-03-27 4:13 ` David Gibson
2015-03-27 10:48 ` Dr. David Alan Gilbert
2015-03-28 16:00 ` Paolo Bonzini
2015-03-30 4:03 ` David Gibson
2015-03-28 15:58 ` Paolo Bonzini
2015-03-28 15:43 ` Paolo Bonzini
2015-03-30 17:46 ` Dr. David Alan Gilbert
2015-03-30 19:23 ` Paolo Bonzini
2015-03-31 11:05 ` Dr. David Alan Gilbert
2015-03-31 11:10 ` Paolo Bonzini
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 18/45] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream Dr. David Alan Gilbert (git)
2015-03-13 0:55 ` David Gibson
2015-03-13 11:51 ` Dr. David Alan Gilbert
2015-03-16 6:16 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 19/45] migrate_init: Call from savevm Dr. David Alan Gilbert (git)
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy Dr. David Alan Gilbert (git)
2015-03-13 1:00 ` David Gibson
2015-03-13 10:19 ` Dr. David Alan Gilbert
2015-03-16 6:18 ` David Gibson
2015-03-20 12:37 ` Dr. David Alan Gilbert
2015-03-23 2:25 ` David Gibson
2015-03-24 20:04 ` Dr. David Alan Gilbert
2015-03-24 22:32 ` David Gibson
2015-03-25 15:00 ` Dr. David Alan Gilbert
2015-03-25 16:40 ` Dr. David Alan Gilbert
2015-03-26 1:35 ` David Gibson
2015-03-26 11:44 ` Dr. David Alan Gilbert
2015-03-27 3:56 ` David Gibson
2015-03-26 1:35 ` David Gibson
2015-03-30 8:10 ` Paolo Bonzini
2015-03-31 0:10 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 21/45] Add Linux userfaultfd header Dr. David Alan Gilbert (git)
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 22/45] postcopy: OS support test Dr. David Alan Gilbert (git)
2015-03-13 1:23 ` David Gibson
2015-03-13 10:41 ` Dr. David Alan Gilbert
2015-03-16 6:22 ` David Gibson
2015-03-30 8:14 ` Paolo Bonzini
2015-03-30 14:07 ` Dr. David Alan Gilbert
2015-03-30 14:09 ` Paolo Bonzini
2015-06-16 10:49 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 23/45] migrate_start_postcopy: Command to trigger transition to postcopy Dr. David Alan Gilbert (git)
2015-03-13 1:26 ` David Gibson
2015-03-13 11:19 ` Dr. David Alan Gilbert
2015-03-16 6:23 ` David Gibson
2015-03-18 17:59 ` Dr. David Alan Gilbert
2015-03-19 4:18 ` David Gibson
2015-03-19 9:33 ` Dr. David Alan Gilbert
2015-03-23 2:20 ` David Gibson
2015-03-30 8:19 ` Paolo Bonzini
2015-03-30 17:04 ` Dr. David Alan Gilbert
2015-03-30 19:22 ` Paolo Bonzini
2015-03-31 11:21 ` Dr. David Alan Gilbert
2015-03-30 8:17 ` Paolo Bonzini
2015-03-31 2:23 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 24/45] MIG_STATE_POSTCOPY_ACTIVE: Add new migration state Dr. David Alan Gilbert (git)
2015-03-13 4:45 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 25/45] qemu_savevm_state_complete: Postcopy changes Dr. David Alan Gilbert (git)
2015-03-13 4:58 ` David Gibson
2015-03-13 12:25 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 26/45] Postcopy page-map-incoming (PMI) structure Dr. David Alan Gilbert (git)
2015-03-13 5:19 ` David Gibson
2015-03-13 13:47 ` Dr. David Alan Gilbert
2015-03-16 6:30 ` David Gibson
2015-03-18 17:58 ` Dr. David Alan Gilbert
2015-03-23 2:48 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 27/45] Postcopy: Maintain sentmap and calculate discard Dr. David Alan Gilbert (git)
2015-03-23 3:30 ` David Gibson
2015-03-23 14:36 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 28/45] postcopy: Incoming initialisation Dr. David Alan Gilbert (git)
2015-03-23 3:41 ` David Gibson
2015-03-23 13:46 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 29/45] postcopy: ram_enable_notify to switch on userfault Dr. David Alan Gilbert (git)
2015-03-23 3:45 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread Dr. David Alan Gilbert (git)
2015-03-23 4:20 ` David Gibson
2015-03-26 11:05 ` Dr. David Alan Gilbert
2015-03-30 8:31 ` Paolo Bonzini [this message]
2015-04-13 11:35 ` Dr. David Alan Gilbert
2015-04-13 13:26 ` Paolo Bonzini
2015-04-13 14:58 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 31/45] Postcopy end in migration_thread Dr. David Alan Gilbert (git)
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 32/45] Page request: Add MIG_RP_CMD_REQ_PAGES reverse command Dr. David Alan Gilbert (git)
2015-03-23 5:00 ` David Gibson
2015-03-25 18:16 ` Dr. David Alan Gilbert
2015-03-26 1:28 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 33/45] Page request: Process incoming page request Dr. David Alan Gilbert (git)
2015-03-24 1:53 ` David Gibson
2015-03-25 17:37 ` Dr. David Alan Gilbert
2015-03-26 1:31 ` David Gibson
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 34/45] Page request: Consume pages off the post-copy queue Dr. David Alan Gilbert (git)
2015-03-24 2:15 ` David Gibson
2015-06-16 10:48 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 35/45] postcopy_ram.c: place_page and helpers Dr. David Alan Gilbert (git)
2015-03-24 2:33 ` David Gibson
2015-03-25 17:46 ` Dr. David Alan Gilbert
2015-02-25 16:51 ` [Qemu-devel] [PATCH v5 36/45] Postcopy: Use helpers to map pages during migration Dr. David Alan Gilbert (git)
2015-03-24 4:51 ` David Gibson
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 37/45] qemu_ram_block_from_host Dr. David Alan Gilbert (git)
2015-03-24 4:55 ` David Gibson
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 38/45] Don't sync dirty bitmaps in postcopy Dr. David Alan Gilbert (git)
2015-03-24 4:58 ` David Gibson
2015-03-24 9:05 ` Dr. David Alan Gilbert
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 39/45] Host page!=target page: Cleanup bitmaps Dr. David Alan Gilbert (git)
2015-03-24 5:23 ` David Gibson
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 40/45] Postcopy; Handle userfault requests Dr. David Alan Gilbert (git)
2015-03-24 5:38 ` David Gibson
2015-03-26 11:59 ` Dr. David Alan Gilbert
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 41/45] Start up a postcopy/listener thread ready for incoming page data Dr. David Alan Gilbert (git)
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 42/45] postcopy: Wire up loadvm_postcopy_handle_{run, end} commands Dr. David Alan Gilbert (git)
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 43/45] End of migration for postcopy Dr. David Alan Gilbert (git)
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 44/45] Disable mlock around incoming postcopy Dr. David Alan Gilbert (git)
2015-03-23 4:33 ` David Gibson
2015-02-25 16:52 ` [Qemu-devel] [PATCH v5 45/45] Inhibit ballooning during postcopy Dr. David Alan Gilbert (git)
2015-03-23 4:32 ` David Gibson
2015-03-23 12:21 ` Dr. David Alan Gilbert
2015-03-24 1:25 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551909CA.7080605@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=amit.shah@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yamahata@private.email.ne.jp \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).