From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcVOr-0005pq-Pj for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:50:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcVOl-0008Q7-6z for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:50:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcVOl-0008Pa-2K for qemu-devel@nongnu.org; Mon, 30 Mar 2015 04:50:19 -0400 Message-ID: <55190E45.1090709@redhat.com> Date: Mon, 30 Mar 2015 10:50:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427704589-7688-1-git-send-email-lma@suse.com> In-Reply-To: <1427704589-7688-1-git-send-email-lma@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 0/2] Add generic can_be_deleted to UserCreatableClass. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lin Ma , imammedo@redhat.com, afaerber@suse.de, peter.crosthwaite@xilinx.com Cc: qemu-devel@nongnu.org On 30/03/2015 10:36, Lin Ma wrote: > The patchset adds a generic can_be_deleted callback to UserCreatableCla= ss. > It prevents removing a usercreatable object if the callback returns fal= se. >=20 > Backends could implement the callback if it shoudn't be removed while i= t's > in use. >=20 > Thank Peter Crosthwaite, Paolo Bonzini, Andreas F=C3=A4rber and Igor Ma= mmedov for > helping review. >=20 >=20 > ChangeLog: > V6: > Change prototype of user_creatable_can_be_deleted. > from bool user_creatable_can_be_deleted(Object *obj, Error **errp) > to bool user_creatable_can_be_deleted(UserCreatable *uc, Error **err= p) >=20 > V5: > Use specific caster instead of dynamic cast in user_creatable_can_be_de= leted. >=20 > V4: > Add function user_creatable_can_be_deleted to wrapper can_be_deleted me= thod. > Remove some unnecessary code. >=20 > V3: > Move the callback to the correct place: UserCreatableClass. > Move the backend callback implementation to hostmem.c. >=20 > V2: > Make it generic, add the can_be_deleted callback to TypeInfo and TypeIm= pl. > Implement the callback in hostmem-file.c and hostmem-ram.c. >=20 > V1: > Initial version, hard coded in object_del to prevent removing an in-use > host memory backend. >=20 >=20 > Lin Ma (2): > qom: Add can_be_deleted callback to UserCreatableClass > hostmem: Prevent removing an in-use memory backend >=20 > backends/hostmem.c | 14 ++++++++++++++ > include/qom/object_interfaces.h | 13 +++++++++++++ > qmp.c | 5 +++++ > qom/object_interfaces.c | 12 ++++++++++++ > 4 files changed, 44 insertions(+) >=20 Thanks, looks good for 2.3. Paolo