From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcYmh-0001gS-4C for qemu-devel@nongnu.org; Mon, 30 Mar 2015 08:27:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcYmc-0007Zt-5b for qemu-devel@nongnu.org; Mon, 30 Mar 2015 08:27:15 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:33192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcYmb-0007Zo-Vh for qemu-devel@nongnu.org; Mon, 30 Mar 2015 08:27:10 -0400 Received: by wixm2 with SMTP id m2so85630622wix.0 for ; Mon, 30 Mar 2015 05:27:09 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55194119.5060507@redhat.com> Date: Mon, 30 Mar 2015 14:27:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427717907-25027-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1427717907-25027-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.3] pc: acpi: fix pvpanic regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: ghammer@redhat.com, mst@redhat.com, rth@twiddle.net On 30/03/2015 14:18, Igor Mammedov wrote: > Commit cd61cb2 pc: acpi-build: generate pvpanic device description dynamically > > introduced regression changing pvpanic device HID from > QEMU0001 to QEMU0002. > Fix AML generated code so that pvpanic device > would keep its original HID. i.e. QEMU0001 > > Signed-off-by: Igor Mammedov > Reported-by: Gal Hammer > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index d0a5c85..e761005 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -788,7 +788,7 @@ build_ssdt(GArray *table_data, GArray *linker, > scope = aml_scope("\\_SB.PCI0.ISA"); > > dev = aml_device("PEVR"); > - aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002"))); > + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0001"))); > > crs = aml_resource_template(); > aml_append(crs, > Pretty obvious, so I can take this through my tree. Paolo