From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcaE0-0001pj-NK for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:59:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcaDy-0005iL-2K for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:59:32 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:37781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcaDx-0005iC-Rq for qemu-devel@nongnu.org; Mon, 30 Mar 2015 09:59:30 -0400 Received: by wiaa2 with SMTP id a2so131188724wia.0 for ; Mon, 30 Mar 2015 06:59:29 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <551956BC.5040605@redhat.com> Date: Mon, 30 Mar 2015 15:59:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427554013-3535-1-git-send-email-fishman@saucelabs.com> <20150330143643.304edf0f@nial.brq.redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] acpi: add reset register to fadt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Reza Jelveh , Igor Mammedov Cc: qemu-devel@nongnu.org On 30/03/2015 15:27, Reza Jelveh wrote: > you are extending structure beyond of what specified by ACPI 1.0b spec, > that might break guests. > We probably can't change revision since Windows ACPI implementation > is mostly 1.0b based so we are stuck with it. > Patch needs to be tested with Windows guests starting with XP. > > Works fine with XP as long as you don't use q35, but i guess that's > unsupported by xp by default. Isn't that just because XP doesn't have an AHCI driver? You should still be able to use XP with q35 and virtio, by using a driver disk. Or add a PATA controller: -device piix4-ide,id=pata \ -drive if=none,id=hd,file=... \ -device ide-hd,drive=hd,bus=pata.0 Paolo