From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YccIx-0001qD-VS for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:12:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YccIw-0001Fv-Sh for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:12:47 -0400 Sender: Paolo Bonzini Message-ID: <551975F3.3080204@redhat.com> Date: Mon, 30 Mar 2015 18:12:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1427651603-9210-1-git-send-email-afaerber@suse.de> <871tk6k1eh.fsf@blackfin.pond.sub.org> In-Reply-To: <871tk6k1eh.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-ppc@nongnu.org, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, qemu-block@nongnu.org, hpoussin@reactos.org On 30/03/2015 16:25, Markus Armbruster wrote: > Andreas Färber writes: > >> Hello Markus et al., >> >> This series attempts to fix the -device pc87312 issues you reported. >> >> I can't add alias properties for devices that don't get created before realize. >> Therefore this involves moving code for various ISA devices, to enable us >> to initialize the objects early for alias properties and realizing them >> as part of the composite device once the configuration is known, also fixing >> error propagation while at it. Probably needs a further iteration. >> >> Yes, it's terribly invasive, that's why the code was as it is. >> But the code movements are quite trivial, as long as no in-air conflicts occur. > > Pity we have to move the state structs to the header, but that what we > have to do to make them embeddable. And I understand embedding is how > we do sub-devices ("part of" instead of "plugged into"). > > Your changes are quite regular. They don't look scary to me, but that > could be just ignorance. They're non-trivial enough though to make wary > of merging them for 2.3 this late. The question is really: what is gained from this series as of 2.3? Is anything actually using "-device pc87312"? It was broken before IIUC, so it can remain broken for one more version. Markus's patches would just add one more "git revert" to this series, basically. Paolo