From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YccOt-00048Q-PF for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:18:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YccOs-0003RG-Hd for qemu-devel@nongnu.org; Mon, 30 Mar 2015 12:18:55 -0400 Message-ID: <55197765.5030801@suse.de> Date: Mon, 30 Mar 2015 18:18:45 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1427651603-9210-1-git-send-email-afaerber@suse.de> <871tk6k1eh.fsf@blackfin.pond.sub.org> <551975F3.3080204@redhat.com> In-Reply-To: <551975F3.3080204@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC for-2.3? 0/8] prep: Fix pc87312 for -device usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-block@nongnu.org, mark.cave-ayland@ilande.co.uk, Markus Armbruster , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, hpoussin@reactos.org Am 30.03.2015 um 18:12 schrieb Paolo Bonzini: > On 30/03/2015 16:25, Markus Armbruster wrote: >> Andreas F=C3=A4rber writes: >> >>> Hello Markus et al., >>> >>> This series attempts to fix the -device pc87312 issues you reported. >>> >>> I can't add alias properties for devices that don't get created befor= e realize. >>> Therefore this involves moving code for various ISA devices, to enabl= e us >>> to initialize the objects early for alias properties and realizing th= em >>> as part of the composite device once the configuration is known, also= fixing >>> error propagation while at it. Probably needs a further iteration. >>> >>> Yes, it's terribly invasive, that's why the code was as it is. >>> But the code movements are quite trivial, as long as no in-air confli= cts occur. >> >> Pity we have to move the state structs to the header, but that what we >> have to do to make them embeddable. And I understand embedding is how >> we do sub-devices ("part of" instead of "plugged into"). >> >> Your changes are quite regular. They don't look scary to me, but that >> could be just ignorance. They're non-trivial enough though to make wa= ry >> of merging them for 2.3 this late. >=20 > The question is really: what is gained from this series as of 2.3? Is > anything actually using "-device pc87312"? It was broken before IIUC, > so it can remain broken for one more version. Markus's patches would > just add one more "git revert" to this series, basically. Well, my intent was to avoid adding FIXMEs by fixing it properly right away. But I don't see an urgent need as long as it's start-up errors and not a device_add-induced crash (not sure here, would need to re-read Markus' thread). Agree that it's getting late. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)