From: Richard Henderson <rth@twiddle.net>
To: Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org
Cc: aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target-mips: save cpu state before calling MSA load and store helpers
Date: Mon, 30 Mar 2015 12:01:38 -0700 [thread overview]
Message-ID: <55199D92.3050203@twiddle.net> (raw)
In-Reply-To: <1426523374-18673-1-git-send-email-leon.alrae@imgtec.com>
On 03/16/2015 09:29 AM, Leon Alrae wrote:
> PC needs to be saved if an exception can be generated by an helper.
> This fixes a problem related to resuming the execution at unexpected address
> after an exception (caused by MSA load/store instruction) has been serviced.
Only if the helper doesn't use cpu_restore_state.
In this case, all of your do_##name memory routines should
instead use helper_[lb]e_*_mmu, which allows you to pass along
the mmu_idx (instead of switching on _kernel et al), and the
GETRA() value in the top-level helper.
r~
prev parent reply other threads:[~2015-03-30 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 16:29 [Qemu-devel] [PATCH] target-mips: save cpu state before calling MSA load and store helpers Leon Alrae
2015-03-30 19:01 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55199D92.3050203@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).