From: "Andreas Färber" <afaerber@suse.de>
To: Kirk Allan <kallan@suse.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32
Date: Mon, 30 Mar 2015 23:15:50 +0200 [thread overview]
Message-ID: <5519BD06.4090701@suse.de> (raw)
In-Reply-To: <551961610200007600129EAE@prv-mh.provo.novell.com>
Hi Kirk,
Am 30.03.2015 um 22:44 schrieb Kirk Allan:
> Ping.
>
> Looking for feedback anyone might have regarding this patch.
I would recommend to make the patch smaller and the commit message more
intuitive by splitting off the configure changes into its own patch
(remember to include a short cover letter then). It feels strange to
have a new configure option for a single -D though... Can't this value
be overridden via --extra-cflags=-D_WINNT_WINVER=0xf00 already?
CC'ing some people that know about Windows might help, too. Stefan W.
comes to mind.
Also note that we're in Hard Freeze for 2.3 at the moment, which shifts
people's attention to bug fixes.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-03-30 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:09 [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32 Kirk Allan
2015-03-30 20:44 ` Kirk Allan
2015-03-30 21:15 ` Andreas Färber [this message]
2015-03-30 22:26 ` Kirk Allan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5519BD06.4090701@suse.de \
--to=afaerber@suse.de \
--cc=kallan@suse.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).