From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ych2M-0003d4-Cz for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:15:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ych2H-0004BG-DV for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:15:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57716 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ych2H-0004B3-78 for qemu-devel@nongnu.org; Mon, 30 Mar 2015 17:15:53 -0400 Message-ID: <5519BD06.4090701@suse.de> Date: Mon, 30 Mar 2015 23:15:50 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1426518542-28222-1-git-send-email-kallan@suse.com> <551961610200007600129EAE@prv-mh.provo.novell.com> In-Reply-To: <551961610200007600129EAE@prv-mh.provo.novell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirk Allan , qemu-devel@nongnu.org Cc: Stefan Weil , mdroth@linux.vnet.ibm.com Hi Kirk, Am 30.03.2015 um 22:44 schrieb Kirk Allan: > Ping. >=20 > Looking for feedback anyone might have regarding this patch. I would recommend to make the patch smaller and the commit message more intuitive by splitting off the configure changes into its own patch (remember to include a short cover letter then). It feels strange to have a new configure option for a single -D though... Can't this value be overridden via --extra-cflags=3D-D_WINNT_WINVER=3D0xf00 already? CC'ing some people that know about Windows might help, too. Stefan W. comes to mind. Also note that we're in Hard Freeze for 2.3 at the moment, which shifts people's attention to bug fixes. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)